Paolo Bonzini writes:
> Il 16/01/2014 03:50, Michael Roth ha scritto:
>> If we go to that effort, it may make sense to try to re-license to GPLv2+
>> while we're at it, but either way I think this should be done as a separate
>> patchset, and shouldn't hold up Wenchao's series. I can send that ou
Il 16/01/2014 03:50, Michael Roth ha scritto:
> If we go to that effort, it may make sense to try to re-license to GPLv2+
> while we're at it, but either way I think this should be done as a separate
> patchset, and shouldn't hold up Wenchao's series. I can send that out, since
> it's my screw-up.
Quoting Markus Armbruster (2013-12-16 03:13:08)
> [Licensing problem, cc: Anthony]
>
> Kevin Wolf writes:
>
> > Am 13.12.2013 um 14:31 hat Eric Blake geschrieben:
> >> On 11/12/2013 06:44 PM, Wenchao Xia wrote:
> >> > +++ b/scripts/qapi-event.py
> >> > @@ -0,0 +1,355 @@
> >> > +#
> >> > +# QAPI
于 2014/1/13 18:08, Markus Armbruster 写道:
> Ping^2!
>
> Markus Armbruster writes:
>
>> Ping?
>>
>> Markus Armbruster writes:
>>
>>> [Licensing problem, cc: Anthony]
>>>
>>> Kevin Wolf writes:
>>>
Am 13.12.2013 um 14:31 hat Eric Blake geschrieben:
> On 11/12/2013 06:44 PM, Wenchao Xia w
Ping^2!
Markus Armbruster writes:
> Ping?
>
> Markus Armbruster writes:
>
>> [Licensing problem, cc: Anthony]
>>
>> Kevin Wolf writes:
>>
>>> Am 13.12.2013 um 14:31 hat Eric Blake geschrieben:
On 11/12/2013 06:44 PM, Wenchao Xia wrote:
> +++ b/scripts/qapi-event.py
> @@ -0,0 +1,
Ping?
Markus Armbruster writes:
> [Licensing problem, cc: Anthony]
>
> Kevin Wolf writes:
>
>> Am 13.12.2013 um 14:31 hat Eric Blake geschrieben:
>>> On 11/12/2013 06:44 PM, Wenchao Xia wrote:
>>> > +++ b/scripts/qapi-event.py
>>> > @@ -0,0 +1,355 @@
>>> > +#
>>> > +# QAPI event generator
>>> >
[Licensing problem, cc: Anthony]
Kevin Wolf writes:
> Am 13.12.2013 um 14:31 hat Eric Blake geschrieben:
>> On 11/12/2013 06:44 PM, Wenchao Xia wrote:
>> > +++ b/scripts/qapi-event.py
>> > @@ -0,0 +1,355 @@
>> > +#
>> > +# QAPI event generator
>> > +#
>> > +# Copyright IBM, Corp. 2013
>> > +#
>>
Wenchao Xia writes:
> 于 2013/12/13 21:43, Kevin Wolf 写道:
>> Am 13.12.2013 um 14:31 hat Eric Blake geschrieben:
>>> On 11/12/2013 06:44 PM, Wenchao Xia wrote:
+++ b/scripts/qapi-event.py
@@ -0,0 +1,355 @@
+#
+# QAPI event generator
+#
+# Copyright IBM, Corp. 2013
于 2013/12/13 21:31, Eric Blake 写道:
On 11/12/2013 06:44 PM, Wenchao Xia wrote:
Nested structure is not supported now, so following define is not valid:
{ 'event': 'EVENT_C',
'data': { 'a': { 'a_a', 'str', 'a_b', 'str' }, 'b': 'int' }
But what IS valid? You need to document this in docs/qapi
于 2013/12/13 21:43, Kevin Wolf 写道:
Am 13.12.2013 um 14:31 hat Eric Blake geschrieben:
On 11/12/2013 06:44 PM, Wenchao Xia wrote:
+++ b/scripts/qapi-event.py
@@ -0,0 +1,355 @@
+#
+# QAPI event generator
+#
+# Copyright IBM, Corp. 2013
+#
+# Authors:
+# Wenchao Xia
+#
+# This work is licensed u
On 11/12/2013 06:44 PM, Wenchao Xia wrote:
> Nested structure is not supported now, so following define is not valid:
> { 'event': 'EVENT_C',
> 'data': { 'a': { 'a_a', 'str', 'a_b', 'str' }, 'b': 'int' }
But what IS valid? You need to document this in docs/qapi-code-gen.txt
at a bare minimum.
Am 13.12.2013 um 14:31 hat Eric Blake geschrieben:
> On 11/12/2013 06:44 PM, Wenchao Xia wrote:
> > +++ b/scripts/qapi-event.py
> > @@ -0,0 +1,355 @@
> > +#
> > +# QAPI event generator
> > +#
> > +# Copyright IBM, Corp. 2013
> > +#
> > +# Authors:
> > +# Wenchao Xia
> > +#
> > +# This work is lic
于 2013/12/2 14:48, Wenchao Xia 写道:
+
+if (!qapi_event_functions.emit) {
Better to return an error here instead of silently failing.
The purpose is allowing emit=NULL and skip event code in that case.
But the code will do nothing and the caller won't know that.
Now the call
+
+if (!qapi_event_functions.emit) {
Better to return an error here instead of silently failing.
The purpose is allowing emit=NULL and skip event code in that case.
But the code will do nothing and the caller won't know that.
Now the caller also won't know that useless code
On Thu, 28 Nov 2013 15:16:08 +0800
Wenchao Xia wrote:
> 于 2013/11/28 8:48, Luiz Capitulino 写道:
> > On Wed, 13 Nov 2013 09:44:52 +0800
> > Wenchao Xia wrote:
> >
> >> Nested structure is not supported now, so following define is not valid:
> >> { 'event': 'EVENT_C',
> >>'data': { 'a': { 'a_a'
于 2013/11/28 8:48, Luiz Capitulino 写道:
On Wed, 13 Nov 2013 09:44:52 +0800
Wenchao Xia wrote:
Nested structure is not supported now, so following define is not valid:
{ 'event': 'EVENT_C',
'data': { 'a': { 'a_a', 'str', 'a_b', 'str' }, 'b': 'int' }
I think your general approach is reasonab
On Wed, 13 Nov 2013 09:44:52 +0800
Wenchao Xia wrote:
> Nested structure is not supported now, so following define is not valid:
> { 'event': 'EVENT_C',
> 'data': { 'a': { 'a_a', 'str', 'a_b', 'str' }, 'b': 'int' }
I think your general approach is reasonable, but there are a number of
details
Nested structure is not supported now, so following define is not valid:
{ 'event': 'EVENT_C',
'data': { 'a': { 'a_a', 'str', 'a_b', 'str' }, 'b': 'int' }
Signed-off-by: Wenchao Xia
---
Makefile |9 +-
Makefile.objs |2 +-
qapi/Makefile.objs|1 +
scripts/qa
18 matches
Mail list logo
