Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-27 Thread Paolo Bonzini
Il 15/05/2014 14:58, Michael S. Tsirkin ha scritto: You are asking for examples of ugly assymetry? It's easy: grep for .load_state_old. You have here a bunch of functions loading format that qemu can no longer produce, with any set of flags. The only way to make them run is to install two qemu ve

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-17 Thread Michael S. Tsirkin
On Thu, May 15, 2014 at 09:04:49AM +0200, Greg Kurz wrote: > On Thu, 15 May 2014 12:16:35 +0530 > Amit Shah wrote: > > On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: > > > On Thu, May 15, 2014 at 11:34:25AM +0530, Amit Shah wrote: > > > > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrot

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-16 Thread Greg Kurz
On Fri, 16 May 2014 17:40:00 +0800 Fam Zheng wrote: > On Fri, 05/16 11:22, Andreas Färber wrote: > > Am 16.05.2014 11:14, schrieb Fam Zheng: > > > On Thu, 05/15 12:08, Greg Kurz wrote: > > The main problem I see is that virtio sucks: as you see in patch 8, we > > have > > to be car

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-16 Thread Fam Zheng
On Fri, 05/16 11:22, Andreas Färber wrote: > Am 16.05.2014 11:14, schrieb Fam Zheng: > > On Thu, 05/15 12:08, Greg Kurz wrote: > The main problem I see is that virtio sucks: as you see in patch 8, we > have > to be careful not to call vring or virtqueue stuff before the device > >>

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-16 Thread Andreas Färber
Am 16.05.2014 11:14, schrieb Fam Zheng: > On Thu, 05/15 12:08, Greg Kurz wrote: The main problem I see is that virtio sucks: as you see in patch 8, we have to be careful not to call vring or virtqueue stuff before the device knows its endianness or it breaks... I need to study how th

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-16 Thread Fam Zheng
On Thu, 05/15 12:08, Greg Kurz wrote: > > > The main problem I see is that virtio sucks: as you see in patch 8, we > > > have > > > to be careful not to call vring or virtqueue stuff before the device knows > > > its endianness or it breaks... I need to study how the virtio-bus gets > > > migrated

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Greg Kurz
On Thu, 15 May 2014 14:00:15 +0200 Andreas Färber wrote: > Am 15.05.2014 12:16, schrieb Michael S. Tsirkin: > > On Thu, May 15, 2014 at 12:11:12PM +0200, Andreas Färber wrote: > >> Am 15.05.2014 12:03, schrieb Michael S. Tsirkin: > >>> On Thu, May 15, 2014 at 11:58:25AM +0200, Andreas Färber wrot

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, May 15, 2014 at 02:00:15PM +0200, Andreas Färber wrote: [...] >> Either subsections work >> with your downstream or they don't; if they don't, then you have much >> larger problems than can be solved by blocking this one section for ppc. >> Therefore I was s

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Greg Kurz
On Thu, 15 May 2014 15:58:16 +0300 "Michael S. Tsirkin" wrote: > On Thu, May 15, 2014 at 02:33:47PM +0200, Markus Armbruster wrote: > > "Michael S. Tsirkin" writes: > > > > > On Thu, May 15, 2014 at 11:20:18AM +0200, Andreas Färber wrote: > > >> Am 15.05.2014 09:04, schrieb Greg Kurz: > > >> >

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Michael S. Tsirkin
On Thu, May 15, 2014 at 02:33:47PM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, May 15, 2014 at 11:20:18AM +0200, Andreas Färber wrote: > >> Am 15.05.2014 09:04, schrieb Greg Kurz: > >> > On Thu, 15 May 2014 12:16:35 +0530 > >> > Amit Shah wrote: > >> >> On (Thu)

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, May 15, 2014 at 11:20:18AM +0200, Andreas Färber wrote: >> Am 15.05.2014 09:04, schrieb Greg Kurz: >> > On Thu, 15 May 2014 12:16:35 +0530 >> > Amit Shah wrote: >> >> On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: >> >>> On Thu, May 15, 2014 at

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Michael S. Tsirkin
On Thu, May 15, 2014 at 02:00:15PM +0200, Andreas Färber wrote: > Am 15.05.2014 12:16, schrieb Michael S. Tsirkin: > > On Thu, May 15, 2014 at 12:11:12PM +0200, Andreas Färber wrote: > >> Am 15.05.2014 12:03, schrieb Michael S. Tsirkin: > >>> On Thu, May 15, 2014 at 11:58:25AM +0200, Andreas Färber

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Andreas Färber
Am 15.05.2014 12:16, schrieb Michael S. Tsirkin: > On Thu, May 15, 2014 at 12:11:12PM +0200, Andreas Färber wrote: >> Am 15.05.2014 12:03, schrieb Michael S. Tsirkin: >>> On Thu, May 15, 2014 at 11:58:25AM +0200, Andreas Färber wrote: Am 15.05.2014 11:52, schrieb Michael S. Tsirkin: > On T

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Greg Kurz
On Thu, 15 May 2014 13:12:12 +0300 "Michael S. Tsirkin" wrote: > On Thu, May 15, 2014 at 12:08:26PM +0200, Greg Kurz wrote: > > On Thu, 15 May 2014 11:20:18 +0200 > > Andreas Färber wrote: > > > Am 15.05.2014 09:04, schrieb Greg Kurz: > > > > On Thu, 15 May 2014 12:16:35 +0530 > > > > Amit Shah

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Michael S. Tsirkin
On Thu, May 15, 2014 at 12:11:12PM +0200, Andreas Färber wrote: > Am 15.05.2014 12:03, schrieb Michael S. Tsirkin: > > On Thu, May 15, 2014 at 11:58:25AM +0200, Andreas Färber wrote: > >> Am 15.05.2014 11:52, schrieb Michael S. Tsirkin: > >>> On Thu, May 15, 2014 at 11:20:18AM +0200, Andreas Färber

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Greg Kurz
On Thu, 15 May 2014 12:08:26 +0200 Greg Kurz wrote: > On Thu, 15 May 2014 11:20:18 +0200 > Andreas Färber wrote: > > Am 15.05.2014 09:04, schrieb Greg Kurz: > > > On Thu, 15 May 2014 12:16:35 +0530 > > > Amit Shah wrote: > > >> On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: > > >>> O

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Michael S. Tsirkin
On Thu, May 15, 2014 at 12:08:26PM +0200, Greg Kurz wrote: > On Thu, 15 May 2014 11:20:18 +0200 > Andreas Färber wrote: > > Am 15.05.2014 09:04, schrieb Greg Kurz: > > > On Thu, 15 May 2014 12:16:35 +0530 > > > Amit Shah wrote: > > >> On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: > >

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Andreas Färber
Am 15.05.2014 12:03, schrieb Michael S. Tsirkin: > On Thu, May 15, 2014 at 11:58:25AM +0200, Andreas Färber wrote: >> Am 15.05.2014 11:52, schrieb Michael S. Tsirkin: >>> On Thu, May 15, 2014 at 11:20:18AM +0200, Andreas Färber wrote: Am 15.05.2014 09:04, schrieb Greg Kurz: > On Thu, 15 Ma

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Greg Kurz
On Thu, 15 May 2014 11:20:18 +0200 Andreas Färber wrote: > Am 15.05.2014 09:04, schrieb Greg Kurz: > > On Thu, 15 May 2014 12:16:35 +0530 > > Amit Shah wrote: > >> On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: > >>> On Thu, May 15, 2014 at 11:34:25AM +0530, Amit Shah wrote: > On

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Michael S. Tsirkin
On Thu, May 15, 2014 at 11:58:25AM +0200, Andreas Färber wrote: > Am 15.05.2014 11:52, schrieb Michael S. Tsirkin: > > On Thu, May 15, 2014 at 11:20:18AM +0200, Andreas Färber wrote: > >> Am 15.05.2014 09:04, schrieb Greg Kurz: > >>> On Thu, 15 May 2014 12:16:35 +0530 > >>> Amit Shah wrote: >

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Andreas Färber
Am 15.05.2014 11:52, schrieb Michael S. Tsirkin: > On Thu, May 15, 2014 at 11:20:18AM +0200, Andreas Färber wrote: >> Am 15.05.2014 09:04, schrieb Greg Kurz: >>> On Thu, 15 May 2014 12:16:35 +0530 >>> Amit Shah wrote: On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: > On Thu, Ma

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Michael S. Tsirkin
On Thu, May 15, 2014 at 11:20:18AM +0200, Andreas Färber wrote: > Am 15.05.2014 09:04, schrieb Greg Kurz: > > On Thu, 15 May 2014 12:16:35 +0530 > > Amit Shah wrote: > >> On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: > >>> On Thu, May 15, 2014 at 11:34:25AM +0530, Amit Shah wrote: > >

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Andreas Färber
Am 15.05.2014 09:04, schrieb Greg Kurz: > On Thu, 15 May 2014 12:16:35 +0530 > Amit Shah wrote: >> On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: >>> On Thu, May 15, 2014 at 11:34:25AM +0530, Amit Shah wrote: On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > Since each virti

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Michael S. Tsirkin
On Thu, May 15, 2014 at 12:16:35PM +0530, Amit Shah wrote: > On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: > > On Thu, May 15, 2014 at 11:34:25AM +0530, Amit Shah wrote: > > > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > > > > There is a need to add some more fields to VirtIODev

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Michael S. Tsirkin
On Thu, May 15, 2014 at 08:49:48AM +0200, Greg Kurz wrote: > On Thu, 15 May 2014 11:34:25 +0530 > Amit Shah wrote: > > > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > > > There is a need to add some more fields to VirtIODevice that should be > > > migrated (broken status, endianness). The p

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-15 Thread Greg Kurz
On Thu, 15 May 2014 12:16:35 +0530 Amit Shah wrote: > On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: > > On Thu, May 15, 2014 at 11:34:25AM +0530, Amit Shah wrote: > > > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > > > > There is a need to add some more fields to VirtIODevice th

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Amit Shah
On (Thu) 15 May 2014 [08:49:48], Greg Kurz wrote: > On Thu, 15 May 2014 11:34:25 +0530 > Amit Shah wrote: > > > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > > > There is a need to add some more fields to VirtIODevice that should be > > > migrated (broken status, endianness). The problem is

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Greg Kurz
On Thu, 15 May 2014 11:34:25 +0530 Amit Shah wrote: > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > > There is a need to add some more fields to VirtIODevice that should be > > migrated (broken status, endianness). The problem is that we do not > > want to break compatibility while adding a

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Amit Shah
On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: > On Thu, May 15, 2014 at 11:34:25AM +0530, Amit Shah wrote: > > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > > > There is a need to add some more fields to VirtIODevice that should be > > > migrated (broken status, endianness). The

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Michael S. Tsirkin
On Thu, May 15, 2014 at 11:34:25AM +0530, Amit Shah wrote: > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > > There is a need to add some more fields to VirtIODevice that should be > > migrated (broken status, endianness). The problem is that we do not > > want to break compatibility while add

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Amit Shah
On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > There is a need to add some more fields to VirtIODevice that should be > migrated (broken status, endianness). The problem is that we do not > want to break compatibility while adding a new feature... This issue has > been addressed in the generic

[Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Greg Kurz
There is a need to add some more fields to VirtIODevice that should be migrated (broken status, endianness). The problem is that we do not want to break compatibility while adding a new feature... This issue has been addressed in the generic VMState code with the use of optional subsections. As a *