Re: [Qemu-devel] [PATCH RFC 1/3] linux-user: add rtnetlink(7) support

2016-05-16 Thread Laurent Vivier
Le 13/05/2016 à 18:40, Peter Maydell a écrit : > On 30 January 2016 at 22:26, Laurent Vivier wrote: >> rtnetlink is needed to use iproute package (ip addr, ip route) >> and dhcp client. >> >> Examples: >> >> Without this patch: >> # ip link >> Cannot open netlink socket: Address family n

Re: [Qemu-devel] [PATCH RFC 1/3] linux-user: add rtnetlink(7) support

2016-05-14 Thread Peter Maydell
On 14 May 2016 at 10:37, Laurent Vivier wrote: > > > Le 13/05/2016 à 18:40, Peter Maydell a écrit : >> On 30 January 2016 at 22:26, Laurent Vivier wrote: >>> +while (len > (int)sizeof(struct nlmsghdr)) { >> >> What is this cast to int for ? >> > > I agree it seems useless, I have copied some

Re: [Qemu-devel] [PATCH RFC 1/3] linux-user: add rtnetlink(7) support

2016-05-13 Thread Peter Maydell
On 30 January 2016 at 22:26, Laurent Vivier wrote: > rtnetlink is needed to use iproute package (ip addr, ip route) > and dhcp client. > > Examples: > > Without this patch: > # ip link > Cannot open netlink socket: Address family not supported by protocol > # ip addr > Cannot open

[Qemu-devel] [PATCH RFC 1/3] linux-user: add rtnetlink(7) support

2016-01-30 Thread Laurent Vivier
rtnetlink is needed to use iproute package (ip addr, ip route) and dhcp client. Examples: Without this patch: # ip link Cannot open netlink socket: Address family not supported by protocol # ip addr Cannot open netlink socket: Address family not supported by protocol # ip rout