Re: [Qemu-devel] [PATCH RFC 1/2] virtio-blk: add DISCARD and WRITE ZEROES features

2019-01-28 Thread Stefano Garzarella
On Sun, Jan 27, 2019 at 12:51:44PM +, Stefan Hajnoczi wrote: > On Fri, Jan 25, 2019 at 05:18:13PM +0100, Stefano Garzarella wrote: > > On Fri, Jan 25, 2019 at 02:58:56PM +, Stefan Hajnoczi wrote: > > > On Thu, Jan 24, 2019 at 06:23:22PM +0100, Stefano Garzarella wrote: > > > > +

Re: [Qemu-devel] [PATCH RFC 1/2] virtio-blk: add DISCARD and WRITE ZEROES features

2019-01-27 Thread Stefan Hajnoczi
On Fri, Jan 25, 2019 at 05:18:13PM +0100, Stefano Garzarella wrote: > On Fri, Jan 25, 2019 at 02:58:56PM +, Stefan Hajnoczi wrote: > > On Thu, Jan 24, 2019 at 06:23:22PM +0100, Stefano Garzarella wrote: > > > +virtio_error(vdev, "virtio-blk discard/wzeroes header too > > > short");

Re: [Qemu-devel] [PATCH RFC 1/2] virtio-blk: add DISCARD and WRITE ZEROES features

2019-01-25 Thread Stefano Garzarella
On Fri, Jan 25, 2019 at 02:58:56PM +, Stefan Hajnoczi wrote: > On Thu, Jan 24, 2019 at 06:23:22PM +0100, Stefano Garzarella wrote: > > @@ -584,6 +603,56 @@ static int virtio_blk_handle_request(VirtIOBlockReq > > *req, MultiReqBuffer *mrb) > > virtio_blk_free_request(req); > >

Re: [Qemu-devel] [PATCH RFC 1/2] virtio-blk: add DISCARD and WRITE ZEROES features

2019-01-25 Thread Stefan Hajnoczi
On Thu, Jan 24, 2019 at 06:23:22PM +0100, Stefano Garzarella wrote: > @@ -584,6 +603,56 @@ static int virtio_blk_handle_request(VirtIOBlockReq > *req, MultiReqBuffer *mrb) > virtio_blk_free_request(req); > break; > } > +/* > + * VIRTIO_BLK_T_DISCARD and VIRTIO_BLK_T_

Re: [Qemu-devel] [PATCH RFC 1/2] virtio-blk: add DISCARD and WRITE ZEROES features

2019-01-24 Thread Stefano Garzarella
On Thu, Jan 24, 2019 at 6:55 PM Dr. David Alan Gilbert wrote: > > * Stefano Garzarella (sgarz...@redhat.com) wrote: > > This patch adds the support of DISCARD and WRITE ZEROES commands, > > that have been introduced in the virtio-blk protocol to have > > better performance when using SSD backend.

Re: [Qemu-devel] [PATCH RFC 1/2] virtio-blk: add DISCARD and WRITE ZEROES features

2019-01-24 Thread Dr. David Alan Gilbert
* Stefano Garzarella (sgarz...@redhat.com) wrote: > This patch adds the support of DISCARD and WRITE ZEROES commands, > that have been introduced in the virtio-blk protocol to have > better performance when using SSD backend. > > Signed-off-by: Stefano Garzarella Hi, Do you need to make those

[Qemu-devel] [PATCH RFC 1/2] virtio-blk: add DISCARD and WRITE ZEROES features

2019-01-24 Thread Stefano Garzarella
This patch adds the support of DISCARD and WRITE ZEROES commands, that have been introduced in the virtio-blk protocol to have better performance when using SSD backend. Signed-off-by: Stefano Garzarella --- hw/block/virtio-blk.c | 79 +++ 1 file changed,