Re: [Qemu-devel] [PATCH RFC 01/13] apic: rename apic specific bitopts

2013-05-13 Thread Michael S. Tsirkin
On Mon, May 13, 2013 at 09:22:20PM +0100, Peter Maydell wrote: > On 13 May 2013 21:00, Michael S. Tsirkin wrote: > > apic has its own version of bitops, with the > > difference that it works on u32 and not long. > > Add apic_ prefix to avoid namespace clashes. > > Wouldn't it be better to consoli

Re: [Qemu-devel] [PATCH RFC 01/13] apic: rename apic specific bitopts

2013-05-13 Thread Peter Maydell
On 13 May 2013 21:00, Michael S. Tsirkin wrote: > apic has its own version of bitops, with the > difference that it works on u32 and not long. > Add apic_ prefix to avoid namespace clashes. Wouldn't it be better to consolidate so we only have one set of bitops rather than a local set in this file

[Qemu-devel] [PATCH RFC 01/13] apic: rename apic specific bitopts

2013-05-13 Thread Michael S. Tsirkin
apic has its own version of bitops, with the difference that it works on u32 and not long. Add apic_ prefix to avoid namespace clashes. Signed-off-by: Michael S. Tsirkin --- hw/intc/apic.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --