Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread John Snow
On 09/08/2015 04:00 AM, Denis V. Lunev wrote: > Description of the problem: > Client and server interacts via Network File System (NFS) or using other > network storage like CEPH. The server contains an image of the Virtual > Machine (VM) with Linux inside. The disk is exposed as SATA or IDE > to

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Fam Zheng
On Tue, 09/08 12:49, Kevin Wolf wrote: > Am 08.09.2015 um 12:20 hat Fam Zheng geschrieben: > > On Tue, 09/08 12:11, Kevin Wolf wrote: > > > Am 08.09.2015 um 11:20 hat Fam Zheng geschrieben: > > > > [Cc'ing qemu-bl...@nongnu.org] > > > > > > > > On Tue, 09/08 11:00, Denis V. Lunev wrote: > > > > >

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Denis V. Lunev
On 09/08/2015 01:37 PM, Andrey Korolyov wrote: On Tue, Sep 8, 2015 at 12:41 PM, Denis V. Lunev wrote: On 09/08/2015 12:33 PM, Paolo Bonzini wrote: On 08/09/2015 10:00, Denis V. Lunev wrote: How the given solution works? If disk-deadlines option is enabled for a drive, one controls time comp

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Kevin Wolf
Am 08.09.2015 um 12:20 hat Fam Zheng geschrieben: > On Tue, 09/08 12:11, Kevin Wolf wrote: > > Am 08.09.2015 um 11:20 hat Fam Zheng geschrieben: > > > [Cc'ing qemu-bl...@nongnu.org] > > > > > > On Tue, 09/08 11:00, Denis V. Lunev wrote: > > > > To avoid such situation this patchset introduces patc

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Denis V. Lunev
On 09/08/2015 01:20 PM, Fam Zheng wrote: On Tue, 09/08 12:11, Kevin Wolf wrote: Am 08.09.2015 um 11:20 hat Fam Zheng geschrieben: [Cc'ing qemu-bl...@nongnu.org] On Tue, 09/08 11:00, Denis V. Lunev wrote: To avoid such situation this patchset introduces patch per-drive option "disk-deadlines=o

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Andrey Korolyov
On Tue, Sep 8, 2015 at 12:41 PM, Denis V. Lunev wrote: > On 09/08/2015 12:33 PM, Paolo Bonzini wrote: >> >> >> On 08/09/2015 10:00, Denis V. Lunev wrote: >>> >>> How the given solution works? >>> >>> If disk-deadlines option is enabled for a drive, one controls time >>> completion >>> of this driv

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Denis V. Lunev
On 09/08/2015 01:22 PM, Stefan Hajnoczi wrote: On Tue, Sep 08, 2015 at 11:33:09AM +0200, Paolo Bonzini wrote: On 08/09/2015 10:00, Denis V. Lunev wrote: How the given solution works? If disk-deadlines option is enabled for a drive, one controls time completion of this drive's requests. The me

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Paolo Bonzini
On 08/09/2015 12:22, Stefan Hajnoczi wrote: > Guests running without this patch series may suffer from the NFS "soft" > mounts problem when they time out and give up on the I/O request just as > it actually completes on the server, leaving the data in a different > state than expected. > > This

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Stefan Hajnoczi
On Tue, Sep 08, 2015 at 11:33:09AM +0200, Paolo Bonzini wrote: > > > On 08/09/2015 10:00, Denis V. Lunev wrote: > > How the given solution works? > > > > If disk-deadlines option is enabled for a drive, one controls time > > completion > > of this drive's requests. The method is as follows (fur

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Fam Zheng
On Tue, 09/08 12:11, Kevin Wolf wrote: > Am 08.09.2015 um 11:20 hat Fam Zheng geschrieben: > > [Cc'ing qemu-bl...@nongnu.org] > > > > On Tue, 09/08 11:00, Denis V. Lunev wrote: > > > To avoid such situation this patchset introduces patch per-drive option > > > "disk-deadlines=on|off" which is unse

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Denis V. Lunev
On 09/08/2015 01:11 PM, Kevin Wolf wrote: Am 08.09.2015 um 11:20 hat Fam Zheng geschrieben: [Cc'ing qemu-bl...@nongnu.org] On Tue, 09/08 11:00, Denis V. Lunev wrote: To avoid such situation this patchset introduces patch per-drive option "disk-deadlines=on|off" which is unset by default. The

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Kevin Wolf
Am 08.09.2015 um 11:20 hat Fam Zheng geschrieben: > [Cc'ing qemu-bl...@nongnu.org] > > On Tue, 09/08 11:00, Denis V. Lunev wrote: > > To avoid such situation this patchset introduces patch per-drive option > > "disk-deadlines=on|off" which is unset by default. > > The general idea sounds very nic

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Denis V. Lunev
On 09/08/2015 01:07 PM, Kevin Wolf wrote: Am 08.09.2015 um 11:33 hat Paolo Bonzini geschrieben: On 08/09/2015 10:00, Denis V. Lunev wrote: How the given solution works? If disk-deadlines option is enabled for a drive, one controls time completion of this drive's requests. The method is as fol

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Kevin Wolf
Am 08.09.2015 um 11:33 hat Paolo Bonzini geschrieben: > > > On 08/09/2015 10:00, Denis V. Lunev wrote: > > How the given solution works? > > > > If disk-deadlines option is enabled for a drive, one controls time > > completion > > of this drive's requests. The method is as follows (further assu

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Paolo Bonzini
On 08/09/2015 11:41, Denis V. Lunev wrote: > This solution is far not perfect as there is a race window for > request complete anyway. Though the amount of failures is > reduced by 2-3 orders of magnitude. > > The behavior is similar not for soft mounts, which could > corrupt the data but to har

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Denis V. Lunev
On 09/08/2015 12:33 PM, Paolo Bonzini wrote: On 08/09/2015 10:00, Denis V. Lunev wrote: How the given solution works? If disk-deadlines option is enabled for a drive, one controls time completion of this drive's requests. The method is as follows (further assume that this option is enabled).

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Paolo Bonzini
On 08/09/2015 10:00, Denis V. Lunev wrote: > How the given solution works? > > If disk-deadlines option is enabled for a drive, one controls time completion > of this drive's requests. The method is as follows (further assume that this > option is enabled). > > Every drive has its own red-black

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Fam Zheng
[Cc'ing qemu-bl...@nongnu.org] On Tue, 09/08 11:00, Denis V. Lunev wrote: > To avoid such situation this patchset introduces patch per-drive option > "disk-deadlines=on|off" which is unset by default. The general idea sounds very nice. Thanks! Should we allow user configuration on the timeout?

Re: [Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Vasiliy Tolstov
2015-09-08 11:00 GMT+03:00 Denis V. Lunev : > > VM remains stopped until all requests from the disk which caused VM's stopping > are completed. Furthermore, if there is another disks with 'disk-deadlines=on' > whose requests are waiting to be completed, do not start VM : wait completion > of all "l

[Qemu-devel] [PATCH RFC 0/5] disk deadlines

2015-09-08 Thread Denis V. Lunev
Description of the problem: Client and server interacts via Network File System (NFS) or using other network storage like CEPH. The server contains an image of the Virtual Machine (VM) with Linux inside. The disk is exposed as SATA or IDE to VM. VM is started on the client as usual. In the case of