Re: [Qemu-devel] [PATCH RFC] error: Include hint everywhere

2017-12-20 Thread Markus Armbruster
Fam Zheng writes: > On Wed, 12/20 10:05, Markus Armbruster wrote: >> Fam Zheng writes: >> >> > On Tue, 12/19 15:29, Markus Armbruster wrote: >> >> Adding Eric for additonal QMP design expertise. >> >> >> >> Fam Zheng writes: >> >> >> >> > Previously we only print hint lines if we are in a co

Re: [Qemu-devel] [PATCH RFC] error: Include hint everywhere

2017-12-20 Thread Fam Zheng
On Wed, 12/20 10:05, Markus Armbruster wrote: > Fam Zheng writes: > > > On Tue, 12/19 15:29, Markus Armbruster wrote: > >> Adding Eric for additonal QMP design expertise. > >> > >> Fam Zheng writes: > >> > >> > Previously we only print hint lines if we are in a command line context > >> > or H

Re: [Qemu-devel] [PATCH RFC] error: Include hint everywhere

2017-12-20 Thread Markus Armbruster
Fam Zheng writes: > On Tue, 12/19 15:29, Markus Armbruster wrote: >> Adding Eric for additonal QMP design expertise. >> >> Fam Zheng writes: >> >> > Previously we only print hint lines if we are in a command line context >> > or HMP. However QMP errors are also eventually consumed by human and

Re: [Qemu-devel] [PATCH RFC] error: Include hint everywhere

2017-12-19 Thread Fam Zheng
On Tue, 12/19 15:29, Markus Armbruster wrote: > Adding Eric for additonal QMP design expertise. > > Fam Zheng writes: > > > Previously we only print hint lines if we are in a command line context > > or HMP. However QMP errors are also eventually consumed by human and the > > hint could help. >

Re: [Qemu-devel] [PATCH RFC] error: Include hint everywhere

2017-12-19 Thread Markus Armbruster
Adding Eric for additonal QMP design expertise. Fam Zheng writes: > Previously we only print hint lines if we are in a command line context > or HMP. However QMP errors are also eventually consumed by human and the > hint could help. > > Append hint lines already in error_get_pretty() and do as

[Qemu-devel] [PATCH RFC] error: Include hint everywhere

2017-12-18 Thread Fam Zheng
Previously we only print hint lines if we are in a command line context or HMP. However QMP errors are also eventually consumed by human and the hint could help. Append hint lines already in error_get_pretty() and do as said above consistently in CLI, HMP and QMP. Signed-off-by: Fam Zheng ---