Re: [Qemu-devel] [PATCH RFC] bcm2835_dma: add emulation of Raspberry Pi DMA controller

2016-03-04 Thread Gerd Hoffmann
Hi, > I guess a more general approach to the problem would be to have > a (hopefully easy) way to say "if this has been going on for too > long then arrange to defer continued processing of it til later, > and for now resume the guest". Doable today, by simply applying some limit and if we hit

Re: [Qemu-devel] [PATCH RFC] bcm2835_dma: add emulation of Raspberry Pi DMA controller

2016-03-03 Thread Andrew Baumann
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Thursday, 3 March 2016 8:22 AM > > On 3 March 2016 at 16:16, Gerd Hoffmann wrote: > > usb emulation has this problem too. > > > > uhci queue heads can go in circles. The emulation code keeps a linked > > list of active queue heads,

Re: [Qemu-devel] [PATCH RFC] bcm2835_dma: add emulation of Raspberry Pi DMA controller

2016-03-03 Thread Peter Maydell
On 3 March 2016 at 16:16, Gerd Hoffmann wrote: > usb emulation has this problem too. > > uhci queue heads can go in circles. The emulation code keeps a linked > list of active queue heads, which is (among other bookkeeping things) > used to detect when we run in circles. It's a legal thing to do

Re: [Qemu-devel] [PATCH RFC] bcm2835_dma: add emulation of Raspberry Pi DMA controller

2016-03-03 Thread Gerd Hoffmann
Hi, > > +ch->cs |= BCM2708_DMA_END; > > +if (ch->ti & BCM2708_DMA_INT_EN) { > > +ch->cs |= BCM2708_DMA_INT; > > +s->int_status |= (1 << c); > > +qemu_set_irq(ch->irq, 1); > > +} > > + > > +/* Process next CB */ > > +ch->

Re: [Qemu-devel] [PATCH RFC] bcm2835_dma: add emulation of Raspberry Pi DMA controller

2016-03-03 Thread Grégory ESTRADE
I'd be glad if you add a sign-off by me, but it doesn't matter much. Having this work finally getting into mainstream thanks to Andrew is what matters there. Best regards, Gregory On Thu, Mar 3, 2016 at 3:24 PM, Peter Maydell wrote: > On 29 February 2016 at 23:11, Andrew Baumann > wrote: > > Si

Re: [Qemu-devel] [PATCH RFC] bcm2835_dma: add emulation of Raspberry Pi DMA controller

2016-03-03 Thread Peter Maydell
On 29 February 2016 at 23:11, Andrew Baumann wrote: > Signed-off-by: Andrew Baumann > --- > This patch applies on top of the previous series for Windows and > framebuffer support: > https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg06387.html > > After preparing that, I was disappointed

[Qemu-devel] [PATCH RFC] bcm2835_dma: add emulation of Raspberry Pi DMA controller

2016-02-29 Thread Andrew Baumann
Signed-off-by: Andrew Baumann --- This patch applies on top of the previous series for Windows and framebuffer support: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg06387.html After preparing that, I was disappointed to discover that Raspbian won't boot cleanly without the DMA contr