Re: [Qemu-devel] [PATCH RFC] Do not set SO_REUSEADDR on Windows

2013-09-05 Thread Michael Tokarev
04.09.2013 18:34, Jan Kiszka wrote: On 2013-09-04 16:27, Paolo Bonzini wrote: Il 04/09/2013 16:22, Sebastian Ottlik ha scritto: This patchset disabels all use of SO_REUSEADDR on Windows. On Windows systems the default behavior is equivalent to SO_REUSEADDR on other operating systems. SO_REUSEAD

Re: [Qemu-devel] [PATCH RFC] Do not set SO_REUSEADDR on Windows

2013-09-04 Thread Paolo Bonzini
Il 04/09/2013 19:31, Stefan Weil ha scritto: > May I suggest a slightly different approach? Instead of a new function > qemu_set_reuseaddr I'd prefer extending the existing qemu_setsockopt. > These steps / patches are required: > > 1. Move *sock* lines from include/qemu-common.h to include/qemu/so

Re: [Qemu-devel] [PATCH RFC] Do not set SO_REUSEADDR on Windows

2013-09-04 Thread Stefan Weil
Am 04.09.2013 16:41, schrieb Peter Maydell: > On 4 September 2013 15:27, Paolo Bonzini wrote: >> Il 04/09/2013 16:22, Sebastian Ottlik ha scritto: >>> This patchset disabels all use of SO_REUSEADDR on Windows. On >>> Windows systems the default behavior is equivalent to SO_REUSEADDR >>> on other o

Re: [Qemu-devel] [PATCH RFC] Do not set SO_REUSEADDR on Windows

2013-09-04 Thread Peter Maydell
On 4 September 2013 15:27, Paolo Bonzini wrote: > Il 04/09/2013 16:22, Sebastian Ottlik ha scritto: >> This patchset disabels all use of SO_REUSEADDR on Windows. On Windows systems >> the default behavior is equivalent to SO_REUSEADDR on other operating >> systems. SO_REUSEADDR can still be set bu

[Qemu-devel] [PATCH RFC] Do not set SO_REUSEADDR on Windows

2013-09-04 Thread Sebastian Ottlik
This patchset disabels all use of SO_REUSEADDR on Windows. On Windows systems the default behavior is equivalent to SO_REUSEADDR on other operating systems. SO_REUSEADDR can still be set but results in undesired bahvior instead. It may even lead to situations were system behavior is unspecified. Mo

Re: [Qemu-devel] [PATCH RFC] Do not set SO_REUSEADDR on Windows

2013-09-04 Thread Paolo Bonzini
Il 04/09/2013 16:22, Sebastian Ottlik ha scritto: > This patchset disabels all use of SO_REUSEADDR on Windows. On Windows systems > the default behavior is equivalent to SO_REUSEADDR on other operating > systems. SO_REUSEADDR can still be set but results in undesired bahvior > instead. It may even

Re: [Qemu-devel] [PATCH RFC] Do not set SO_REUSEADDR on Windows

2013-09-04 Thread Sebastian Ottlik
On 04.09.2013 16:27, Paolo Bonzini wrote: Il 04/09/2013 16:22, Sebastian Ottlik ha scritto: This patchset disabels all use of SO_REUSEADDR on Windows. On Windows systems the default behavior is equivalent to SO_REUSEADDR on other operating systems. SO_REUSEADDR can still be set but results in un

Re: [Qemu-devel] [PATCH RFC] Do not set SO_REUSEADDR on Windows

2013-09-04 Thread Jan Kiszka
On 2013-09-04 16:27, Paolo Bonzini wrote: > Il 04/09/2013 16:22, Sebastian Ottlik ha scritto: >> This patchset disabels all use of SO_REUSEADDR on Windows. On Windows systems >> the default behavior is equivalent to SO_REUSEADDR on other operating >> systems. SO_REUSEADDR can still be set but resul