Re: [Qemu-devel] [PATCH RESEND 22/50] blockdev: Check BB validity in drive-backup TA

2015-01-28 Thread Max Reitz
On 2015-01-27 at 18:44, Eric Blake wrote: On 01/27/2015 12:45 PM, Max Reitz wrote: In the drive-backup transaction, call blk_is_available() before using blk_bs() to obtain the root BlockDriverState behind the BlockBackend. Took me a while to figure that TA meant transaction in the subject. Eith

[Qemu-devel] [PATCH RESEND 22/50] blockdev: Check BB validity in drive-backup TA

2015-01-27 Thread Max Reitz
In the drive-backup transaction, call blk_is_available() before using blk_bs() to obtain the root BlockDriverState behind the BlockBackend. Signed-off-by: Max Reitz --- blockdev.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/blockdev.c b/blockdev.c index 0

Re: [Qemu-devel] [PATCH RESEND 22/50] blockdev: Check BB validity in drive-backup TA

2015-01-27 Thread Eric Blake
On 01/27/2015 12:45 PM, Max Reitz wrote: > In the drive-backup transaction, call blk_is_available() before using > blk_bs() to obtain the root BlockDriverState behind the BlockBackend. Took me a while to figure that TA meant transaction in the subject. Either spell it out, or just drop 'TA' entire