On 09/04/2011 07:27 PM, Blue Swirl wrote:
>> to be really necessary). So let's simply clear all queued
>> commands for the current device: */
>> -id = current_tag&0xff00;
>> -QTAILQ_FOREACH_SAFE(p,&s->queue, next, p_next) {
>>
On 4 September 2011 17:20, Avi Kivity wrote:
> Why not keep id declared in the outer scope? This extra indentation is
> annoying.
Personally I find that in a 125 line long function, declaring
a variable at function scope when it's actually used only in
a very small section of the code makes for
On Sun, Sep 4, 2011 at 4:20 PM, Avi Kivity wrote:
> On 09/04/2011 06:53 PM, Blue Swirl wrote:
>>
>> Avoid this warning from clang analyzer by adjusting the scope
>> of the variable:
>> /src/qemu/hw/lsi53c895a.c:895:5: warning: Value stored to 'id' is never
>> read
>> id = (current_tag>> 8)&
On 09/04/2011 06:53 PM, Blue Swirl wrote:
Avoid this warning from clang analyzer by adjusting the scope
of the variable:
/src/qemu/hw/lsi53c895a.c:895:5: warning: Value stored to 'id' is never read
id = (current_tag>> 8)& 0xf;
Signed-off-by: Blue Swirl
---
hw/lsi53c895a.c | 14 +++
Avoid this warning from clang analyzer by adjusting the scope
of the variable:
/src/qemu/hw/lsi53c895a.c:895:5: warning: Value stored to 'id' is never read
id = (current_tag >> 8) & 0xf;
Signed-off-by: Blue Swirl
---
hw/lsi53c895a.c | 14 --
1 files changed, 8 insertions(+), 6
