Re: [Qemu-devel] [PATCH 8/8] qcow2: Fix error path in qcow2_snapshot_load_tmp

2011-11-18 Thread Kevin Wolf
Am 18.11.2011 17:45, schrieb Stefan Hajnoczi: > On Thu, Nov 17, 2011 at 3:13 PM, Kevin Wolf wrote: >> +s->l1_table = new_l1_table; >> +g_free(s->l1_table); > > O_o .oO( immediately frees new_l1_table?! ) This was just a test to see if you're still awake at patch 8. *cough* Ok, I guess

Re: [Qemu-devel] [PATCH 8/8] qcow2: Fix error path in qcow2_snapshot_load_tmp

2011-11-18 Thread Stefan Hajnoczi
On Thu, Nov 17, 2011 at 3:13 PM, Kevin Wolf wrote: > +    s->l1_table = new_l1_table; > +    g_free(s->l1_table); O_o .oO( immediately frees new_l1_table?! ) Stefan

[Qemu-devel] [PATCH 8/8] qcow2: Fix error path in qcow2_snapshot_load_tmp

2011-11-17 Thread Kevin Wolf
If the bdrv_read() of the snapshot's L1 table fails, return the right error code and make sure that the old L1 table is still loaded and we don't break the BlockDriverState completely. Signed-off-by: Kevin Wolf --- block/qcow2-snapshot.c | 33 + 1 files changed,