Re: [Qemu-devel] [PATCH 8/8] hw/i386: fix unbounded stack for load_multiboot

2016-03-08 Thread Peter Xu
On Tue, Mar 08, 2016 at 01:29:21PM +0100, Paolo Bonzini wrote: > > > On 08/03/2016 08:00, Peter Xu wrote: > > @@ -159,6 +159,12 @@ int load_multiboot(FWCfgState *fw_cfg, > > uint8_t *mb_bootinfo_data; > > uint32_t cmdline_len; > > > > +#define __KERN_FNAME_LEN (1024) > > +#define __KE

Re: [Qemu-devel] [PATCH 8/8] hw/i386: fix unbounded stack for load_multiboot

2016-03-08 Thread Paolo Bonzini
On 08/03/2016 08:00, Peter Xu wrote: > @@ -159,6 +159,12 @@ int load_multiboot(FWCfgState *fw_cfg, > uint8_t *mb_bootinfo_data; > uint32_t cmdline_len; > > +#define __KERN_FNAME_LEN (1024) > +#define __KERN_CMDLINE_LEN (4096) > + > +assert(strlen(kernel_filename) + 1 >= __KERN_FNA

Re: [Qemu-devel] [PATCH 8/8] hw/i386: fix unbounded stack for load_multiboot

2016-03-07 Thread Peter Maydell
On 8 March 2016 at 14:00, Peter Xu wrote: > Suggested-by: Paolo Bonzini > CC: Paolo Bonzini > CC: Richard Henderson > CC: Eduardo Habkost > CC: "Michael S. Tsirkin" > Signed-off-by: Peter Xu > --- > hw/i386/multiboot.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > di

[Qemu-devel] [PATCH 8/8] hw/i386: fix unbounded stack for load_multiboot

2016-03-07 Thread Peter Xu
Suggested-by: Paolo Bonzini CC: Paolo Bonzini CC: Richard Henderson CC: Eduardo Habkost CC: "Michael S. Tsirkin" Signed-off-by: Peter Xu --- hw/i386/multiboot.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c index 9e164