Re: [Qemu-devel] [PATCH 7/9] spice: add mouse

2010-08-20 Thread Anthony Liguori
On 08/20/2010 09:03 AM, Gerd Hoffmann wrote: Hi, Again this is libspice interface (and I think also wire protocol), so I can't change it. I can convert dz into some button_mask bits before calling kbd_mouse_event, but looking at the vnc code it seems qemu expects the mouse wheel events being

Re: [Qemu-devel] [PATCH 7/9] spice: add mouse

2010-08-20 Thread Gerd Hoffmann
Hi, Again this is libspice interface (and I think also wire protocol), so I can't change it. I can convert dz into some button_mask bits before calling kbd_mouse_event, but looking at the vnc code it seems qemu expects the mouse wheel events being passed via dz not button_state. That's unfor

Re: [Qemu-devel] [PATCH 7/9] spice: add mouse

2010-08-20 Thread Anthony Liguori
On 08/20/2010 07:42 AM, Gerd Hoffmann wrote: Hi, +static void mouse_motion(SpiceMouseInstance *sin, int dx, int dy, int dz, + uint32_t buttons_state) +{ + kbd_mouse_event(dx, dy, dz, buttons_state); dz is an odd interface. We use it to represent additional buttons which really makes no sens

Re: [Qemu-devel] [PATCH 7/9] spice: add mouse

2010-08-20 Thread Gerd Hoffmann
Hi, +static void mouse_motion(SpiceMouseInstance *sin, int dx, int dy, int dz, + uint32_t buttons_state) +{ + kbd_mouse_event(dx, dy, dz, buttons_state); dz is an odd interface. We use it to represent additional buttons which really makes no sense. If you still can, I'd suggest moving dz int

Re: [Qemu-devel] [PATCH 7/9] spice: add mouse

2010-08-19 Thread Anthony Liguori
On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: Open mouse channel. Now you can move the guests mouse pointer. No tablet / absolute positioning (yet) though. Signed-off-by: Gerd Hoffmann --- spice-input.c | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 7/9] spice: add mouse

2010-08-19 Thread Gerd Hoffmann
Open mouse channel. Now you can move the guests mouse pointer. No tablet / absolute positioning (yet) though. Signed-off-by: Gerd Hoffmann --- spice-input.c | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-) diff --git a/spice-input.c b/spice-input.c inde