Re: [Qemu-devel] [PATCH 7/9] asn1_input-visitor.diff

2013-03-13 Thread Stefan Berger
On 03/13/2013 09:22 PM, Joel Schopp wrote: +case 0x41: +case 0x40: +num.mpn.sign = ((number.first & 0x1) != 0); +num.mpn.biased_exponent = ~0; +num.mpn.mantissa_low = 0; +num.mpn.mantissa_high = 0; +*obj = num.v_double; Is this really portable en

Re: [Qemu-devel] [PATCH 7/9] asn1_input-visitor.diff

2013-03-13 Thread Joel Schopp
+case 0x41: +case 0x40: +num.mpn.sign = ((number.first & 0x1) != 0); +num.mpn.biased_exponent = ~0; +num.mpn.mantissa_low = 0; +num.mpn.mantissa_high = 0; +*obj = num.v_double; Is this really portable enough? In other words, do we really require

Re: [Qemu-devel] [PATCH 7/9] asn1_input-visitor.diff

2013-03-13 Thread Stefan Berger
On 03/13/2013 04:51 PM, Eric Blake wrote: On 03/12/2013 09:09 PM, Joel Schopp wrote: Implement an input visitor for ASN.1 BER encoding. Cc: Michael Tsirkin Signed-off-by: Stefan Berger Signed-off-by: Joel Schopp --- include/qapi/ber-input-visitor.h | 30 ++ qapi/Makefile.objs

Re: [Qemu-devel] [PATCH 7/9] asn1_input-visitor.diff

2013-03-13 Thread Eric Blake
On 03/12/2013 09:09 PM, Joel Schopp wrote: > Implement an input visitor for ASN.1 BER encoding. > > Cc: Michael Tsirkin > Signed-off-by: Stefan Berger > Signed-off-by: Joel Schopp > --- > include/qapi/ber-input-visitor.h | 30 ++ > qapi/Makefile.objs |2 +- > qapi/ber-input

[Qemu-devel] [PATCH 7/9] asn1_input-visitor.diff

2013-03-13 Thread Joel Schopp
Implement an input visitor for ASN.1 BER encoding. Cc: Michael Tsirkin Signed-off-by: Stefan Berger Signed-off-by: Joel Schopp --- include/qapi/ber-input-visitor.h | 30 ++ qapi/Makefile.objs |2 +- qapi/ber-input-visitor.c | 1073 +++

[Qemu-devel] [PATCH 7/9] asn1_input-visitor.diff

2013-03-12 Thread Joel Schopp
Implement an input visitor for ASN.1 BER encoding. Cc: Michael Tsirkin Signed-off-by: Stefan Berger Signed-off-by: Joel Schopp --- include/qapi/ber-input-visitor.h | 30 ++ qapi/Makefile.objs |2 +- qapi/ber-input-visitor.c | 1073 +++