Re: [Qemu-devel] [PATCH 7/8] target/ppc: introduce vsrh_offset() function

2019-03-05 Thread Mark Cave-Ayland
On 03/03/2019 23:33, Richard Henderson wrote: > On 3/3/19 9:23 AM, Mark Cave-Ayland wrote: >> -static inline int fpr_offset(int i) >> +static inline int vsrh_offset(int i) > > I don't agree with this. The original is clearer for its uses. Well as the patchset was coming from a VSX perspective,

Re: [Qemu-devel] [PATCH 7/8] target/ppc: introduce vsrh_offset() function

2019-03-03 Thread Richard Henderson
On 3/3/19 9:23 AM, Mark Cave-Ayland wrote: > -static inline int fpr_offset(int i) > +static inline int vsrh_offset(int i) I don't agree with this. The original is clearer for its uses. r~

[Qemu-devel] [PATCH 7/8] target/ppc: introduce vsrh_offset() function

2019-03-03 Thread Mark Cave-Ayland
Now that both VSX and VMX registers are in host-endian order we can introduce a vsrh_offset() function as a replacement for fpr_offset(). In addition the avrh_offset() and avrl_offset() functions can be simplified in terms of vsrh_offset() and vsrl_offset(). Signed-off-by: Mark Cave-Ayland ---