Re: [Qemu-devel] [PATCH 7/8] qmp: print dirty bitmap

2015-01-30 Thread Eric Blake
On 01/30/2015 02:06 AM, Vladimir Sementsov-Ogievskiy wrote: > is it better to add qmp_query_dirty_bitmap with underlying > bdrv_query_dirty_bitmap, or to modify (add dirty regions information) > existing qmp_query_block/qmp_query_dirty_bitmapS? [please don't top-post on technical lists] Extending

Re: [Qemu-devel] [PATCH 7/8] qmp: print dirty bitmap

2015-01-30 Thread Vladimir Sementsov-Ogievskiy
is it better to add qmp_query_dirty_bitmap with underlying bdrv_query_dirty_bitmap, or to modify (add dirty regions information) existing qmp_query_block/qmp_query_dirty_bitmapS? Best regards, Vladimir On 27.01.2015 18:53, Eric Blake wrote: On 01/13/2015 10:02 AM, Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH 7/8] qmp: print dirty bitmap

2015-01-27 Thread Markus Armbruster
Eric Blake writes: > On 01/13/2015 10:02 AM, Vladimir Sementsov-Ogievskiy wrote: >> Adds qmp and hmp commands to print dirty bitmap. This is needed only for >> testing persistent dirty bitmap feature. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- > >> +++ b/block.c >> @@ -5445,6 +544

Re: [Qemu-devel] [PATCH 7/8] qmp: print dirty bitmap

2015-01-27 Thread Eric Blake
On 01/13/2015 10:02 AM, Vladimir Sementsov-Ogievskiy wrote: > Adds qmp and hmp commands to print dirty bitmap. This is needed only for > testing persistent dirty bitmap feature. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > +++ b/block.c > @@ -5445,6 +5445,39 @@ int bdrv_store_dirty_bi

[Qemu-devel] [PATCH 7/8] qmp: print dirty bitmap

2015-01-13 Thread Vladimir Sementsov-Ogievskiy
Adds qmp and hmp commands to print dirty bitmap. This is needed only for testing persistent dirty bitmap feature. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 33 + blockdev.c| 13 + hmp-commands.hx | 15 +++