Re: [Qemu-devel] [PATCH 7/8] PPC: Turn hardcoded reset mask into env variable

2012-06-21 Thread Alexander Graf
On 21.06.2012, at 20:09, Blue Swirl wrote: > On Wed, Jun 20, 2012 at 8:11 PM, Alexander Graf wrote: >> Some machines have MSR bits they reset with as enabled. Don't hardcode the >> logic, but let the individual core implementations save their own reset >> mask into an env variable. >> >> Sign

Re: [Qemu-devel] [PATCH 7/8] PPC: Turn hardcoded reset mask into env variable

2012-06-21 Thread Peter Maydell
On 20 June 2012 21:11, Alexander Graf wrote: > +    env->reset_msr = (1ULL < MSR_SF); I assume you mean "<<" rather than "<" here and below... -- PMM

Re: [Qemu-devel] [PATCH 7/8] PPC: Turn hardcoded reset mask into env variable

2012-06-21 Thread Blue Swirl
On Wed, Jun 20, 2012 at 8:11 PM, Alexander Graf wrote: > Some machines have MSR bits they reset with as enabled. Don't hardcode the > logic, but let the individual core implementations save their own reset > mask into an env variable. > > Signed-off-by: Alexander Graf > --- >  target-ppc/cpu.h  

[Qemu-devel] [PATCH 7/8] PPC: Turn hardcoded reset mask into env variable

2012-06-20 Thread Alexander Graf
Some machines have MSR bits they reset with as enabled. Don't hardcode the logic, but let the individual core implementations save their own reset mask into an env variable. Signed-off-by: Alexander Graf --- target-ppc/cpu.h|1 + target-ppc/translate_init.c | 14 --