Re: [Qemu-devel] [PATCH 7/7] s390: make sclp ascii console the default

2012-07-26 Thread Andreas Färber
Am 25.07.2012 08:55, schrieb Christian Borntraeger: > On 24/07/12 21:35, Blue Swirl wrote: > [...] >> Braces > [...] >> Braces, also below two times. > > a generic question. We did it that way because the other code in vl.c is like > that. > > So we should make new code follow the CodingStyle ev

Re: [Qemu-devel] [PATCH 7/7] s390: make sclp ascii console the default

2012-07-24 Thread Christian Borntraeger
On 24/07/12 21:35, Blue Swirl wrote: [...] > Braces [...] > Braces, also below two times. a generic question. We did it that way because the other code in vl.c is like that. So we should make new code follow the CodingStyle even if the surrounding code looks different, but we dont touch that su

Re: [Qemu-devel] [PATCH 7/7] s390: make sclp ascii console the default

2012-07-24 Thread Blue Swirl
On Tue, Jul 24, 2012 at 7:37 AM, Christian Borntraeger wrote: > This patch makes the sclp ascii default for S390. > > Signed-off-by: Christian Borntraeger > --- > hw/s390-virtio.c |1 - > vl.c | 44 > 2 files changed, 44 insertions(+

[Qemu-devel] [PATCH 7/7] s390: make sclp ascii console the default

2012-07-24 Thread Christian Borntraeger
This patch makes the sclp ascii default for S390. Signed-off-by: Christian Borntraeger --- hw/s390-virtio.c |1 - vl.c | 44 2 files changed, 44 insertions(+), 1 deletions(-) diff --git a/hw/s390-virtio.c b/hw/s390-virtio.c index 28