Re: [Qemu-devel] [PATCH 6/9] target-xtensa: implement FP0 arithmetic

2012-09-09 Thread Peter Maydell
On 9 September 2012 13:25, Max Filippov wrote: > On Sun, Sep 9, 2012 at 2:05 PM, Peter Maydell > wrote: >> Given that these are just 'v &= 0x7fff' and 'v ^= 0x8000' >> it seems like it would be better to just generate code for them >> rather than calling out to a helper, though in some w

Re: [Qemu-devel] [PATCH 6/9] target-xtensa: implement FP0 arithmetic

2012-09-09 Thread Max Filippov
On Sun, Sep 9, 2012 at 2:05 PM, Peter Maydell wrote: > On 9 September 2012 02:29, Max Filippov wrote: >> +float32 HELPER(abs_s)(float32 v) >> +{ >> +return float32_abs(v); >> +} >> + >> +float32 HELPER(neg_s)(float32 v) >> +{ >> +return float32_chs(v); >> +} > > Given that these are just

Re: [Qemu-devel] [PATCH 6/9] target-xtensa: implement FP0 arithmetic

2012-09-09 Thread Peter Maydell
On 9 September 2012 02:29, Max Filippov wrote: > +float32 HELPER(abs_s)(float32 v) > +{ > +return float32_abs(v); > +} > + > +float32 HELPER(neg_s)(float32 v) > +{ > +return float32_chs(v); > +} Given that these are just 'v &= 0x7fff' and 'v ^= 0x8000' it seems like it would be be

[Qemu-devel] [PATCH 6/9] target-xtensa: implement FP0 arithmetic

2012-09-08 Thread Max Filippov
These are FP arithmetic opcodes. See ISA, 4.3.10 for more details. Signed-off-by: Max Filippov --- target-xtensa/helper.h|7 + target-xtensa/op_helper.c | 37 +++ target-xtensa/translate.c | 61 - 3 files changed