Re: [Qemu-devel] [PATCH 6/9] spice: add keyboard

2010-08-20 Thread Daniel P. Berrange
On Fri, Aug 20, 2010 at 04:49:20PM +0200, Gerd Hoffmann wrote: > Hi, > > >AT (well XT) keycodes aren't that bad a choice, at least if you go for the > >extended mapping used by the Linux keyboard driver. > > Hmm, as far I know those extended mappings are not standardized. Uses > linux this ju

Re: [Qemu-devel] [PATCH 6/9] spice: add keyboard

2010-08-20 Thread Gerd Hoffmann
Hi, AT (well XT) keycodes aren't that bad a choice, at least if you go for the extended mapping used by the Linux keyboard driver. Hmm, as far I know those extended mappings are not standardized. Uses linux this just as internal representation? Or can you actually feed a linux guest with

Re: [Qemu-devel] [PATCH 6/9] spice: add keyboard

2010-08-20 Thread Daniel P. Berrange
On Fri, Aug 20, 2010 at 03:56:52PM +0200, Gerd Hoffmann wrote: > Hi, > > >It's not actually ps/2 data. It's AT scan codes plus an internal > >encoding to indicate press vs. release using the high bit. Additionally, > >some special keys are encoded with two calls to kbd_put_keycode using > >the 0

Re: [Qemu-devel] [PATCH 6/9] spice: add keyboard

2010-08-20 Thread Gerd Hoffmann
Hi, It's not actually ps/2 data. It's AT scan codes plus an internal encoding to indicate press vs. release using the high bit. Additionally, some special keys are encoded with two calls to kbd_put_keycode using the 0xe0 prefix (the grey code). Wheee. From a brief look at the code it seems

Re: [Qemu-devel] [PATCH 6/9] spice: add keyboard

2010-08-20 Thread Anthony Liguori
On 08/20/2010 07:34 AM, Gerd Hoffmann wrote: +static const SpiceKbdInterface kbd_interface = { + .base.type = SPICE_INTERFACE_KEYBOARD, + .base.description = "qemu keyboard", + .base.major_version = SPICE_INTERFACE_KEYBOARD_MAJOR, + .base.minor_version = SPICE_INTERFACE_KEYBOARD_MINOR, + .push_

Re: [Qemu-devel] [PATCH 6/9] spice: add keyboard

2010-08-20 Thread Gerd Hoffmann
+static const SpiceKbdInterface kbd_interface = { + .base.type = SPICE_INTERFACE_KEYBOARD, + .base.description = "qemu keyboard", + .base.major_version = SPICE_INTERFACE_KEYBOARD_MAJOR, + .base.minor_version = SPICE_INTERFACE_KEYBOARD_MINOR, + .push_scan_freg = kbd_push_key, + .get_leds = kbd_ge

Re: [Qemu-devel] [PATCH 6/9] spice: add keyboard

2010-08-19 Thread Anthony Liguori
On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: Open keyboard channel. Now you can type into the spice client and the keyboard events are sent to your guest. You'll need some other display like vnc to actually see the guest responding to them though. Signed-off-by: Gerd Hoffmann --- Makefile.ob

[Qemu-devel] [PATCH 6/9] spice: add keyboard

2010-08-19 Thread Gerd Hoffmann
Open keyboard channel. Now you can type into the spice client and the keyboard events are sent to your guest. You'll need some other display like vnc to actually see the guest responding to them though. Signed-off-by: Gerd Hoffmann --- Makefile.objs |2 +- qemu-spice.h |1 + spice-inp