Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-19 Thread Denis V. Lunev
On 03/14/2016 07:40 PM, Paolo Bonzini wrote: On 14/03/2016 17:16, Denis V. Lunev wrote: BTW, I'm not against adding this to QEMU in general - just pointing out that in the context of libvirt usage reference in the commit message, it is not really needed. I'm totally ambivalent wrt adding this t

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-19 Thread Daniel P. Berrange
On Wed, Mar 16, 2016 at 02:11:31PM +0100, Paolo Bonzini wrote: > > > On 16/03/2016 14:09, Denis V. Lunev wrote: > > really interesting approach with a good place to get in. > > But we will need to modify this a infrastructure a bit. > > Af far as I can see only data from VM to outside world > > i

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-18 Thread Paolo Bonzini
On 16/03/2016 14:09, Denis V. Lunev wrote: > really interesting approach with a good place to get in. > But we will need to modify this a infrastructure a bit. > Af far as I can see only data from VM to outside world > is logged. Data being 'read' should be logged too as far > as I could understa

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Denis V. Lunev
On 03/14/2016 05:38 PM, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 03:33:53PM +0100, Paolo Bonzini wrote: On 14/03/2016 12:21, Denis V. Lunev wrote: From: Pavel Butsykin This log would be very welcome for long-term diagnostics of the system in the production. This log is at least nece

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 17:16, Denis V. Lunev wrote: >> BTW, I'm not against adding this to QEMU in general - just pointing out >> that in the context of libvirt usage reference in the commit message, >> it is not really needed. I'm totally ambivalent wrt adding this to QEMU >> for benefit of non-libvirt u

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 17:10, Denis V. Lunev wrote: > On 03/14/2016 06:26 PM, Daniel P. Berrange wrote: >> On Mon, Mar 14, 2016 at 06:05:07PM +0300, Denis V. Lunev wrote: >>> On 03/14/2016 05:38 PM, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 03:33:53PM +0100, Paolo Bonzini wrote: > On 14/0

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Denis V. Lunev
On 03/14/2016 07:11 PM, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 03:26:04PM +, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 06:05:07PM +0300, Denis V. Lunev wrote: On 03/14/2016 05:38 PM, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 03:33:53PM +0100, Paolo Bonzini wrote:

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Daniel P. Berrange
On Mon, Mar 14, 2016 at 03:26:04PM +, Daniel P. Berrange wrote: > On Mon, Mar 14, 2016 at 06:05:07PM +0300, Denis V. Lunev wrote: > > On 03/14/2016 05:38 PM, Daniel P. Berrange wrote: > > >On Mon, Mar 14, 2016 at 03:33:53PM +0100, Paolo Bonzini wrote: > > >> > > >>On 14/03/2016 12:21, Denis V.

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Denis V. Lunev
On 03/14/2016 06:26 PM, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 06:05:07PM +0300, Denis V. Lunev wrote: On 03/14/2016 05:38 PM, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 03:33:53PM +0100, Paolo Bonzini wrote: On 14/03/2016 12:21, Denis V. Lunev wrote: From: Pavel Butsykin

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Daniel P. Berrange
On Mon, Mar 14, 2016 at 06:05:07PM +0300, Denis V. Lunev wrote: > On 03/14/2016 05:38 PM, Daniel P. Berrange wrote: > >On Mon, Mar 14, 2016 at 03:33:53PM +0100, Paolo Bonzini wrote: > >> > >>On 14/03/2016 12:21, Denis V. Lunev wrote: > >>>From: Pavel Butsykin > >>> > >>>This log would be very welc

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Denis V. Lunev
On 03/14/2016 05:38 PM, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 03:33:53PM +0100, Paolo Bonzini wrote: On 14/03/2016 12:21, Denis V. Lunev wrote: From: Pavel Butsykin This log would be very welcome for long-term diagnostics of the system in the production. This log is at least nece

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Daniel P. Berrange
On Mon, Mar 14, 2016 at 03:33:53PM +0100, Paolo Bonzini wrote: > > > On 14/03/2016 12:21, Denis V. Lunev wrote: > > From: Pavel Butsykin > > > > This log would be very welcome for long-term diagnostics of the system > > in the production. This log is at least necessary to understand what > > ha

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 12:21, Denis V. Lunev wrote: > From: Pavel Butsykin > > This log would be very welcome for long-term diagnostics of the system > in the production. This log is at least necessary to understand what > has been happened on the system and to identify issues at higher-level > subsyste

[Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Denis V. Lunev
From: Pavel Butsykin This log would be very welcome for long-term diagnostics of the system in the production. This log is at least necessary to understand what has been happened on the system and to identify issues at higher-level subsystems (libvirt, etc). These messages will be quite useful t