Re: [Qemu-devel] [PATCH 6/7] qdev: use int32_t container for devfn property

2012-05-01 Thread Andreas Färber
Am 27.04.2012 22:21, schrieb Michael Roth: > Valid range for devfn is -1 to 255 (-1 for automatic assignment). We do > not currently validate this due to devfn being stored as a uint32_t. > This can lead to segfaults and other strange behavior. > > We could technically just cast it to int32_t to i

[Qemu-devel] [PATCH 6/7] qdev: use int32_t container for devfn property

2012-04-27 Thread Michael Roth
Valid range for devfn is -1 to 255 (-1 for automatic assignment). We do not currently validate this due to devfn being stored as a uint32_t. This can lead to segfaults and other strange behavior. We could technically just cast it to int32_t to implement the checking, but this will not work for vis

[Qemu-devel] [PATCH 6/7] qdev: use int32_t container for devfn property

2012-03-28 Thread Michael Roth
Valid range for devfn is -1 to 255 (-1 for automatic assignment). We do not currently validate this due to devfn being stored as a uint32_t. This can lead to segfaults and other strange behavior. We could technically just cast it to int32_t to implement the checking, but this will not work for vis