Re: [Qemu-devel] [PATCH 6/6] target-i386: Call cpu_exec_init() on realize

2015-03-05 Thread Eduardo Habkost
On Thu, Mar 05, 2015 at 05:44:58PM +0100, Andreas Färber wrote: > Am 05.03.2015 um 17:42 schrieb Igor Mammedov: [...] > >> @@ -2840,7 +2842,6 @@ static void x86_cpu_initfn(Object *obj) > >> CPUX86State *env = &cpu->env; > >> > >> cs->env_ptr = env; > >> -cpu_exec_init(env); > > look

Re: [Qemu-devel] [PATCH 6/6] target-i386: Call cpu_exec_init() on realize

2015-03-05 Thread Andreas Färber
Am 05.03.2015 um 17:42 schrieb Igor Mammedov: > On Thu, 5 Mar 2015 12:38:50 -0300 > Eduardo Habkost wrote: > >> To allow new code to ask the CPU classes for CPU model information and >> allow QOM properties to be queried by qmp_device_list_properties(), we >> need to be able to safely instantiat

Re: [Qemu-devel] [PATCH 6/6] target-i386: Call cpu_exec_init() on realize

2015-03-05 Thread Igor Mammedov
On Thu, 5 Mar 2015 12:38:50 -0300 Eduardo Habkost wrote: > To allow new code to ask the CPU classes for CPU model information and > allow QOM properties to be queried by qmp_device_list_properties(), we > need to be able to safely instantiate a X86CPU object without any > side-effects. > > cpu_

[Qemu-devel] [PATCH 6/6] target-i386: Call cpu_exec_init() on realize

2015-03-05 Thread Eduardo Habkost
To allow new code to ask the CPU classes for CPU model information and allow QOM properties to be queried by qmp_device_list_properties(), we need to be able to safely instantiate a X86CPU object without any side-effects. cpu_exec_init() has lots of side-effects on global QEMU state, move it to re