Re: [Qemu-devel] [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-26 Thread Markus Armbruster
Christoph Hellwig writes: > On Fri, Jul 22, 2011 at 04:51:17PM +0200, Hannes Reinecke wrote: >> Not every command is support for any device type. This patch adds >> a check for rejecting unsupported commands. >> >> Signed-off-by: Hannes Reinecke > > This seems to conflic with Markus' series. B

Re: [Qemu-devel] [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-26 Thread Hannes Reinecke
On 07/26/2011 03:46 PM, Kevin Wolf wrote: Am 22.07.2011 16:51, schrieb Hannes Reinecke: Not every command is support for any device type. This patch adds a check for rejecting unsupported commands. Signed-off-by: Hannes Reinecke We do emulate SEEK (6), but it's not in your scsi_cmd_table at a

Re: [Qemu-devel] [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-26 Thread Kevin Wolf
Am 22.07.2011 16:51, schrieb Hannes Reinecke: > Not every command is support for any device type. This patch adds > a check for rejecting unsupported commands. > > Signed-off-by: Hannes Reinecke We do emulate SEEK (6), but it's not in your scsi_cmd_table at all. > --- > hw/scsi-disk.c | 104

Re: [Qemu-devel] [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-26 Thread Christoph Hellwig
On Fri, Jul 22, 2011 at 04:51:17PM +0200, Hannes Reinecke wrote: > Not every command is support for any device type. This patch adds > a check for rejecting unsupported commands. > > Signed-off-by: Hannes Reinecke This seems to conflic with Markus' series. But if we want to invest any major eff

Re: [Qemu-devel] [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-26 Thread Hannes Reinecke
On 07/26/2011 03:07 PM, Kevin Wolf wrote: Am 22.07.2011 16:51, schrieb Hannes Reinecke: Not every command is support for any device type. This patch adds a check for rejecting unsupported commands. Signed-off-by: Hannes Reinecke --- hw/scsi-disk.c | 104 ++

Re: [Qemu-devel] [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-26 Thread Kevin Wolf
Am 22.07.2011 16:51, schrieb Hannes Reinecke: > Not every command is support for any device type. This patch adds > a check for rejecting unsupported commands. > > Signed-off-by: Hannes Reinecke > --- > hw/scsi-disk.c | 104 > +++- > 1 files

[Qemu-devel] [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-22 Thread Hannes Reinecke
Not every command is support for any device type. This patch adds a check for rejecting unsupported commands. Signed-off-by: Hannes Reinecke --- hw/scsi-disk.c | 104 +++- 1 files changed, 103 insertions(+), 1 deletions(-) diff --git a/hw/scs