Re: [Qemu-devel] [PATCH 6/6] migration: catch unknown flags in ram_load

2014-06-17 Thread Eric Blake
On 06/17/2014 03:31 AM, Peter Lieven wrote: >> Among other things, switching from a chain of if-else to a switch might >> make it easier to document explicit supported combinations of flags and >> reject other values from an invalid stream. >> > > Is this what you have in mind? > > diff --git a/a

Re: [Qemu-devel] [PATCH 6/6] migration: catch unknown flags in ram_load

2014-06-17 Thread Peter Lieven
On 16.06.2014 19:31, Eric Blake wrote: On 06/15/2014 09:15 PM, Juan Quintela wrote: From: Peter Lieven if a saved vm has unknown flags in the memory data qemu currently simply ignores this flag and continues which yields in an unpredictable result. This patch catches all unknown flags and abo

Re: [Qemu-devel] [PATCH 6/6] migration: catch unknown flags in ram_load

2014-06-16 Thread Eric Blake
On 06/15/2014 09:15 PM, Juan Quintela wrote: > From: Peter Lieven > > if a saved vm has unknown flags in the memory data qemu > currently simply ignores this flag and continues which > yields in an unpredictable result. > > This patch catches all unknown flags and aborts the > loading of the vm.

[Qemu-devel] [PATCH 6/6] migration: catch unknown flags in ram_load

2014-06-15 Thread Juan Quintela
From: Peter Lieven if a saved vm has unknown flags in the memory data qemu currently simply ignores this flag and continues which yields in an unpredictable result. This patch catches all unknown flags and aborts the loading of the vm. Additionally error reports are thrown if the migration abort