Re: [Qemu-devel] [PATCH 6/6] docker: Open dockerfiles in text mode

2018-06-27 Thread Eduardo Habkost
On Wed, Jun 27, 2018 at 07:51:01AM -0500, Eric Blake wrote: > On 06/26/2018 09:14 PM, Eduardo Habkost wrote: > > Instead of treating dockerfile contents as byte sequences, always > > open dockerfiles in text mode and treat it as text. > > > > This is not strictly required to make the script compat

Re: [Qemu-devel] [PATCH 6/6] docker: Open dockerfiles in text mode

2018-06-27 Thread Eric Blake
On 06/26/2018 09:14 PM, Eduardo Habkost wrote: Instead of treating dockerfile contents as byte sequences, always open dockerfiles in text mode and treat it as text. This is not strictly required to make the script compatible with Python 3, but it's a simpler and safer way than opening dockerfile

[Qemu-devel] [PATCH 6/6] docker: Open dockerfiles in text mode

2018-06-26 Thread Eduardo Habkost
Instead of treating dockerfile contents as byte sequences, always open dockerfiles in text mode and treat it as text. This is not strictly required to make the script compatible with Python 3, but it's a simpler and safer way than opening dockerfiles in binary mode and decoding the data data later