Re: [Qemu-devel] [PATCH 5/9] target/arm: Add aa32_vfp_dreg/aa64_vfp_qreg helpers

2018-01-12 Thread Richard Henderson
On 01/12/2018 10:44 AM, Peter Maydell wrote: >> if (arm_feature(env, ARM_FEATURE_NEON)) { >> nregs += 16; >> if (reg < nregs) { >> -env->vfp.regs[(reg - 32) * 2] = ldfq_le_p(buf); >> -env->vfp.regs[(reg - 32) * 2 + 1] = ldfq_le_p(buf + 8); >> +

Re: [Qemu-devel] [PATCH 5/9] target/arm: Add aa32_vfp_dreg/aa64_vfp_qreg helpers

2018-01-12 Thread Peter Maydell
On 18 December 2017 at 17:30, Richard Henderson wrote: > Helpers that return a pointer into env->vfp.regs so that we isolate > the logic of how to index the regs array for different cpu modes. > > Signed-off-by: Richard Henderson > --- a/target/arm/helper.c > +++ b/target/arm/helper.c > @@ -64,1

Re: [Qemu-devel] [PATCH 5/9] target/arm: Add aa32_vfp_dreg/aa64_vfp_qreg helpers

2018-01-12 Thread Richard Henderson
On 01/12/2018 10:24 AM, Peter Maydell wrote: >> +/** >> + * aa32_vfp_dreg: >> + * Return a pointer to the Dn register within env in 32-bit mode. >> + */ >> +static inline uint64_t *aa32_vfp_dreg(CPUARMState *env, unsigned regno) >> +{ >> +return &env->vfp.regs[regno]; >> +} >> + >> +/** >> + *

Re: [Qemu-devel] [PATCH 5/9] target/arm: Add aa32_vfp_dreg/aa64_vfp_qreg helpers

2018-01-12 Thread Peter Maydell
On 18 December 2017 at 17:30, Richard Henderson wrote: > Helpers that return a pointer into env->vfp.regs so that we isolate > the logic of how to index the regs array for different cpu modes. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 20 +++- > li

Re: [Qemu-devel] [PATCH 5/9] target/arm: Add aa32_vfp_dreg/aa64_vfp_qreg helpers

2018-01-11 Thread Richard Henderson
On 01/11/2018 10:39 AM, Peter Maydell wrote: > On 18 December 2017 at 17:30, Richard Henderson > wrote: >> Helpers that return a pointer into env->vfp.regs so that we isolate >> the logic of how to index the regs array for different cpu modes. >> >> Signed-off-by: Richard Henderson >> --- >> tar

Re: [Qemu-devel] [PATCH 5/9] target/arm: Add aa32_vfp_dreg/aa64_vfp_qreg helpers

2018-01-11 Thread Peter Maydell
On 18 December 2017 at 17:30, Richard Henderson wrote: > Helpers that return a pointer into env->vfp.regs so that we isolate > the logic of how to index the regs array for different cpu modes. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 20 +++- > li

[Qemu-devel] [PATCH 5/9] target/arm: Add aa32_vfp_dreg/aa64_vfp_qreg helpers

2017-12-18 Thread Richard Henderson
Helpers that return a pointer into env->vfp.regs so that we isolate the logic of how to index the regs array for different cpu modes. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 20 +++- linux-user/signal.c| 22 -- target/arm/arch