Re: [Qemu-devel] [PATCH 5/9] spice: core bits

2010-08-25 Thread Gerd Hoffmann
Hi, I think there's two paths we can take here. We can either use module_init() with a new class for this location or we can be more explicit and pass the option list here. Actually the device_init() hook does just fine here. Not sure this is a good idea to hook there though as this is mea

Re: [Qemu-devel] [PATCH 5/9] spice: core bits

2010-08-20 Thread Gerd Hoffmann
+#ifdef CONFIG_SPICE Now's probably a good time to make vm_config_groups a list that can be dynamically added to so that you can register the option group from within spice.c. This would require a new qemu_opts_parse() that took a name of an QemuOptsList instead of the pointer to it but then yo

Re: [Qemu-devel] [PATCH 5/9] spice: core bits

2010-08-19 Thread Anthony Liguori
On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: Add -spice command line switch. Has support setting passwd and port for now. With this patch applied the spice client can successfully connect to qemu. You can't do anything useful yet though. Signed-off-by: Gerd Hoffmann --- Makefile.objs |

[Qemu-devel] [PATCH 5/9] spice: core bits

2010-08-19 Thread Gerd Hoffmann
Add -spice command line switch. Has support setting passwd and port for now. With this patch applied the spice client can successfully connect to qemu. You can't do anything useful yet though. Signed-off-by: Gerd Hoffmann --- Makefile.objs |2 + qemu-config.c | 23 qemu-con