Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread Stefan Berger
On 03/14/2013 05:06 PM, mdroth wrote: On Thu, Mar 14, 2013 at 11:24:03AM -0400, Stefan Berger wrote: On 03/14/2013 11:11 AM, mdroth wrote: On Thu, Mar 14, 2013 at 10:51:49AM -0400, Stefan Berger wrote: On 03/14/2013 10:28 AM, mdroth wrote: On Thu, Mar 14, 2013 at 09:39:14AM -0400, Stefan Berg

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 11:24:03AM -0400, Stefan Berger wrote: > On 03/14/2013 11:11 AM, mdroth wrote: > >On Thu, Mar 14, 2013 at 10:51:49AM -0400, Stefan Berger wrote: > >>On 03/14/2013 10:28 AM, mdroth wrote: > >>>On Thu, Mar 14, 2013 at 09:39:14AM -0400, Stefan Berger wrote: > On 03/14/2013

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread Stefan Berger
On 03/14/2013 11:11 AM, mdroth wrote: On Thu, Mar 14, 2013 at 10:51:49AM -0400, Stefan Berger wrote: On 03/14/2013 10:28 AM, mdroth wrote: On Thu, Mar 14, 2013 at 09:39:14AM -0400, Stefan Berger wrote: On 03/14/2013 08:18 AM, mdroth wrote: On Wed, Mar 13, 2013 at 09:48:11PM -0400, Stefan Berg

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 10:51:49AM -0400, Stefan Berger wrote: > On 03/14/2013 10:28 AM, mdroth wrote: > >On Thu, Mar 14, 2013 at 09:39:14AM -0400, Stefan Berger wrote: > >>On 03/14/2013 08:18 AM, mdroth wrote: > >>>On Wed, Mar 13, 2013 at 09:48:11PM -0400, Stefan Berger wrote: > On 03/13/2013

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread Stefan Berger
On 03/14/2013 10:28 AM, mdroth wrote: On Thu, Mar 14, 2013 at 09:39:14AM -0400, Stefan Berger wrote: On 03/14/2013 08:18 AM, mdroth wrote: On Wed, Mar 13, 2013 at 09:48:11PM -0400, Stefan Berger wrote: On 03/13/2013 07:18 PM, mdroth wrote: On Wed, Mar 13, 2013 at 06:00:24PM -0400, Stefan Berg

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 09:39:14AM -0400, Stefan Berger wrote: > On 03/14/2013 08:18 AM, mdroth wrote: > >On Wed, Mar 13, 2013 at 09:48:11PM -0400, Stefan Berger wrote: > >>On 03/13/2013 07:18 PM, mdroth wrote: > >>>On Wed, Mar 13, 2013 at 06:00:24PM -0400, Stefan Berger wrote: > On 03/13/2013

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread Stefan Berger
On 03/14/2013 08:18 AM, mdroth wrote: On Wed, Mar 13, 2013 at 09:48:11PM -0400, Stefan Berger wrote: On 03/13/2013 07:18 PM, mdroth wrote: On Wed, Mar 13, 2013 at 06:00:24PM -0400, Stefan Berger wrote: On 03/13/2013 04:52 PM, mdroth wrote: Visitors don't have any knowledge of the data struct

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread mdroth
On Wed, Mar 13, 2013 at 09:48:11PM -0400, Stefan Berger wrote: > On 03/13/2013 07:18 PM, mdroth wrote: > >On Wed, Mar 13, 2013 at 06:00:24PM -0400, Stefan Berger wrote: > >>On 03/13/2013 04:52 PM, mdroth wrote: > >> > >Visitors don't have any knowledge of the data structures they're visiting > >out

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-13 Thread Stefan Berger
On 03/13/2013 07:18 PM, mdroth wrote: On Wed, Mar 13, 2013 at 06:00:24PM -0400, Stefan Berger wrote: On 03/13/2013 04:52 PM, mdroth wrote: Visitors don't have any knowledge of the data structures they're visiting outside of what we tell them via the visit_*() API. [...] For example, a visito

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 06:00:24PM -0400, Stefan Berger wrote: > On 03/13/2013 04:52 PM, mdroth wrote: > >On Wed, Mar 13, 2013 at 01:56:24PM -0500, Joel Schopp wrote: > >>Add a sized buffer interface to qapi. > >Isn't this just a special case of the visit_*_carray() interfaces? We > >should avoid n

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-13 Thread Stefan Berger
On 03/13/2013 04:52 PM, mdroth wrote: On Wed, Mar 13, 2013 at 01:56:24PM -0500, Joel Schopp wrote: Add a sized buffer interface to qapi. Isn't this just a special case of the visit_*_carray() interfaces? We should avoid new interfaces if possible, since it adds to feature disparities between vi

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 01:56:24PM -0500, Joel Schopp wrote: > Add a sized buffer interface to qapi. Isn't this just a special case of the visit_*_carray() interfaces? We should avoid new interfaces if possible, since it adds to feature disparities between visitor implementations. > > Cc: Michae

[Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-13 Thread Joel Schopp
Add a sized buffer interface to qapi. Cc: Michael Tsirkin Signed-off-by: Stefan Berger Signed-off-by: Joel Schopp --- include/qapi/visitor-impl.h |2 ++ include/qapi/visitor.h |2 ++ qapi/qapi-visit-core.c |8 3 files changed, 12 insertions(+) diff --git a/inclu

[Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-12 Thread Joel Schopp
Add a sized buffer interface to qapi. Cc: Michael Tsirkin Signed-off-by: Stefan Berger Signed-off-by: Joel Schopp --- include/qapi/visitor-impl.h |2 ++ include/qapi/visitor.h |2 ++ qapi/qapi-visit-core.c |8 3 files changed, 12 insertions(+) diff --git a/inclu