Re: [Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error object

2012-10-23 Thread Luiz Capitulino
On Tue, 23 Oct 2012 12:08:56 +0200 Kevin Wolf wrote: > >> qemu-img doesn't have an HMP monitor, so it doesn't hurt either. If you > >> want to replace it, replace it with a copy of qemu-error.c that only > >> removes the monitor_vprintf() case. That is, in particular, leave all of > >> the loc_*(

Re: [Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error object

2012-10-23 Thread Kevin Wolf
Am 23.10.2012 11:58, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 18.10.2012 15:49, schrieb Luiz Capitulino: >>> On Thu, 18 Oct 2012 14:11:40 +0200 >>> Kevin Wolf wrote: >>> Am 17.10.2012 21:35, schrieb Luiz Capitulino: > Signed-off-by: Luiz Capitulino > --- > qemu-

Re: [Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error object

2012-10-23 Thread Markus Armbruster
Kevin Wolf writes: > Am 18.10.2012 15:49, schrieb Luiz Capitulino: >> On Thu, 18 Oct 2012 14:11:40 +0200 >> Kevin Wolf wrote: >> >>> Am 17.10.2012 21:35, schrieb Luiz Capitulino: Signed-off-by: Luiz Capitulino --- qemu-img.c | 10 +++--- 1 file changed, 7 insertions(+)

Re: [Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error object

2012-10-18 Thread Kevin Wolf
Am 18.10.2012 15:49, schrieb Luiz Capitulino: > On Thu, 18 Oct 2012 14:11:40 +0200 > Kevin Wolf wrote: > >> Am 17.10.2012 21:35, schrieb Luiz Capitulino: >>> Signed-off-by: Luiz Capitulino >>> --- >>> qemu-img.c | 10 +++--- >>> 1 file changed, 7 insertions(+), 3 deletions(-) >>> >>> diff -

Re: [Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error object

2012-10-18 Thread Luiz Capitulino
On Thu, 18 Oct 2012 14:11:40 +0200 Kevin Wolf wrote: > Am 17.10.2012 21:35, schrieb Luiz Capitulino: > > Signed-off-by: Luiz Capitulino > > --- > > qemu-img.c | 10 +++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/qemu-img.c b/qemu-img.c > > index 12fb6c2..df

Re: [Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error object

2012-10-18 Thread Kevin Wolf
Am 17.10.2012 21:35, schrieb Luiz Capitulino: > Signed-off-by: Luiz Capitulino > --- > qemu-img.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 12fb6c2..dfde588 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -302,6 +302,7 @

[Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error object

2012-10-17 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qemu-img.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 12fb6c2..dfde588 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -302,6 +302,7 @@ static int img_create(int argc, char **argv) const char *ba