Re: [Qemu-devel] [PATCH 5/7] target-arm: Add isread parameter to CPAccessFns

2016-02-06 Thread Sergey Fedorov
On 03.02.2016 16:38, Peter Maydell wrote: > System registers might have access requirements which need to > be described via a CPAccessFn and which differ for reads and > writes. For this to be possible we need to pass the access > function a parameter to tell it whether the access being checked >

Re: [Qemu-devel] [PATCH 5/7] target-arm: Add isread parameter to CPAccessFns

2016-02-06 Thread Edgar E. Iglesias
On Wed, Feb 03, 2016 at 01:38:39PM +, Peter Maydell wrote: > System registers might have access requirements which need to > be described via a CPAccessFn and which differ for reads and > writes. For this to be possible we need to pass the access > function a parameter to tell it whether the ac

Re: [Qemu-devel] [PATCH 5/7] target-arm: Add isread parameter to CPAccessFns

2016-02-05 Thread Peter Maydell
On 5 February 2016 at 16:17, Alex Bennée wrote: > > Peter Maydell writes: >> I haven't measured, no, but since there are only 3 arguments the >> third argument is going to be in a register on any host architecture >> we care about, which means the overhead is just going to be a single >> "load co

Re: [Qemu-devel] [PATCH 5/7] target-arm: Add isread parameter to CPAccessFns

2016-02-05 Thread Alex Bennée
Peter Maydell writes: > On 5 February 2016 at 16:17, Alex Bennée wrote: >> >> Peter Maydell writes: >>> I haven't measured, no, but since there are only 3 arguments the >>> third argument is going to be in a register on any host architecture >>> we care about, which means the overhead is just

Re: [Qemu-devel] [PATCH 5/7] target-arm: Add isread parameter to CPAccessFns

2016-02-05 Thread Alex Bennée
Peter Maydell writes: > On 5 February 2016 at 14:20, Alex Bennée wrote: >> >> Peter Maydell writes: >>> -typedef CPAccessResult CPAccessFn(CPUARMState *env, const ARMCPRegInfo >>> *opaque); >>> +typedef CPAccessResult CPAccessFn(CPUARMState *env, >>> + const A

Re: [Qemu-devel] [PATCH 5/7] target-arm: Add isread parameter to CPAccessFns

2016-02-05 Thread Peter Maydell
On 5 February 2016 at 14:20, Alex Bennée wrote: > > Peter Maydell writes: >> -typedef CPAccessResult CPAccessFn(CPUARMState *env, const ARMCPRegInfo >> *opaque); >> +typedef CPAccessResult CPAccessFn(CPUARMState *env, >> + const ARMCPRegInfo *opaque, >> +

Re: [Qemu-devel] [PATCH 5/7] target-arm: Add isread parameter to CPAccessFns

2016-02-05 Thread Alex Bennée
Peter Maydell writes: > System registers might have access requirements which need to > be described via a CPAccessFn and which differ for reads and > writes. For this to be possible we need to pass the access > function a parameter to tell it whether the access being checked > is a read or a wr

[Qemu-devel] [PATCH 5/7] target-arm: Add isread parameter to CPAccessFns

2016-02-03 Thread Peter Maydell
System registers might have access requirements which need to be described via a CPAccessFn and which differ for reads and writes. For this to be possible we need to pass the access function a parameter to tell it whether the access being checked is a read or a write. Signed-off-by: Peter Maydell