Re: [Qemu-devel] [PATCH 5/7] target/sparc: Handle bus errors in mmu_probe()

2019-08-01 Thread Richard Henderson
On 8/1/19 11:30 AM, Peter Maydell wrote: > +/* > + * TODO: MMU probe operations are supposed to set the fault > + * status registers, but we don't do this. > + */ Well, the todo should be using sparc_cpu_tlb_fill with probe=true, since this function appears to be otherwise redundan

[Qemu-devel] [PATCH 5/7] target/sparc: Handle bus errors in mmu_probe()

2019-08-01 Thread Peter Maydell
Convert the mmu_probe() function to using address_space_ldl() rather than ldl_phys(), so we can explicitly detect memory transaction failures. This makes no practical difference at the moment, because ldl_phys() will return 0 on a transaction failure, and we treat transaction failures and 0 PDEs i