Re: [Qemu-devel] [PATCH 5/7] scsi-disk: add need_fua_emulation to SCSIDiskClass

2016-05-24 Thread Paolo Bonzini
On 24/05/2016 05:04, Fam Zheng wrote: > On Mon, 05/23 14:54, Paolo Bonzini wrote: > > scsi-block will be able to do FUA just by passing the request through > > to the LUN (which is also more efficient); there is no need to emulate > > it like we do for scsi-disk. > > Even for scsi-disk, shall we

Re: [Qemu-devel] [PATCH 5/7] scsi-disk: add need_fua_emulation to SCSIDiskClass

2016-05-23 Thread Fam Zheng
On Mon, 05/23 14:54, Paolo Bonzini wrote: > scsi-block will be able to do FUA just by passing the request through > to the LUN (which is also more efficient); there is no need to emulate > it like we do for scsi-disk. Even for scsi-disk, shall we just use the block layer FUA fallback already by pa

Re: [Qemu-devel] [PATCH 5/7] scsi-disk: add need_fua_emulation to SCSIDiskClass

2016-05-23 Thread Eric Blake
On 05/23/2016 06:54 AM, Paolo Bonzini wrote: > scsi-block will be able to do FUA just by passing the request through > to the LUN (which is also more efficient); there is no need to emulate > it like we do for scsi-disk. > > Add a new method to distinguish this. > > Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 5/7] scsi-disk: add need_fua_emulation to SCSIDiskClass

2016-05-23 Thread Paolo Bonzini
scsi-block will be able to do FUA just by passing the request through to the LUN (which is also more efficient); there is no need to emulate it like we do for scsi-disk. Add a new method to distinguish this. Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 9 +++-- 1 file changed, 7 i