Re: [Qemu-devel] [PATCH 5/7] qapi: add query-cpudefs command

2012-07-27 Thread Eric Blake
On 07/27/2012 07:37 AM, Anthony Liguori wrote: > This command attempts to map to the behavior of -cpu ?. Unfortunately, the > output of this command differs wildly across targets. > > To accomodate this, we use a weak symbol to implement a default version of the s/accomodate/accommodate/ > comm

Re: [Qemu-devel] [PATCH 5/7] qapi: add query-cpudefs command

2012-07-27 Thread Luiz Capitulino
On Fri, 27 Jul 2012 08:37:17 -0500 Anthony Liguori wrote: > This command attempts to map to the behavior of -cpu ?. Unfortunately, the > output of this command differs wildly across targets. > > To accomodate this, we use a weak symbol to implement a default version of the > command that fails

Re: [Qemu-devel] [PATCH 5/7] qapi: add query-cpudefs command

2012-07-27 Thread Anthony Liguori
Peter Maydell writes: > On 27 July 2012 14:37, Anthony Liguori wrote: >> This command attempts to map to the behavior of -cpu ?. Unfortunately, the >> output of this command differs wildly across targets. > > I've never really understood why so much of the cpu selection > logic is deferred to t

Re: [Qemu-devel] [PATCH 5/7] qapi: add query-cpudefs command

2012-07-27 Thread Peter Maydell
On 27 July 2012 14:37, Anthony Liguori wrote: > This command attempts to map to the behavior of -cpu ?. Unfortunately, the > output of this command differs wildly across targets. I've never really understood why so much of the cpu selection logic is deferred to target-*... > To accomodate this,

[Qemu-devel] [PATCH 5/7] qapi: add query-cpudefs command

2012-07-27 Thread Anthony Liguori
This command attempts to map to the behavior of -cpu ?. Unfortunately, the output of this command differs wildly across targets. To accomodate this, we use a weak symbol to implement a default version of the command that fails with a QERR_NOT_SUPPORTED error code. Targets can then override and i