Re: [Qemu-devel] [PATCH 5/7] disas: arm-a64: Make printfer and stream variable

2015-05-05 Thread Richard Henderson
On 05/04/2015 09:45 PM, Peter Crosthwaite wrote: > -explicit QEMUDisassembler(FILE *stream) : stream_(stream) { } > +explicit QEMUDisassembler() { } The explicit is no longer helpful, and I'd still initialize stream_ to null. r~

Re: [Qemu-devel] [PATCH 5/7] disas: arm-a64: Make printfer and stream variable

2015-05-05 Thread Claudio Fontana
On 05.05.2015 06:45, Peter Crosthwaite wrote: > In a normal disassembly flow, the printf and stream being used varies > from disas job to job. In particular it varies if mixing monitor_disas > and target_disas. > > Make both the printfer function and target stream settable in the > QEMUDisassmbler

[Qemu-devel] [PATCH 5/7] disas: arm-a64: Make printfer and stream variable

2015-05-04 Thread Peter Crosthwaite
In a normal disassembly flow, the printf and stream being used varies from disas job to job. In particular it varies if mixing monitor_disas and target_disas. Make both the printfer function and target stream settable in the QEMUDisassmbler class. Remove the stream_ initialisation from the constru