Re: [Qemu-devel] [PATCH 5/7] add json encoder for qobjects

2009-10-17 Thread Anthony Liguori
Paolo Bonzini wrote: On 10/17/2009 03:03 PM, Anthony Liguori wrote: I think it makes more sense as an external entity. Maybe... I just thought of it as a toString method that happens to emit JSON. json is one representation of the monitor protocol. I think we should attempt to design thi

Re: [Qemu-devel] [PATCH 5/7] add json encoder for qobjects

2009-10-17 Thread Paolo Bonzini
On 10/17/2009 03:03 PM, Anthony Liguori wrote: I think it makes more sense as an external entity. Maybe... I just thought of it as a toString method that happens to emit JSON. Paolo

Re: [Qemu-devel] [PATCH 5/7] add json encoder for qobjects

2009-10-17 Thread Anthony Liguori
Paolo Bonzini wrote: The JSON encoder is just a virtual method on QObject. I think it makes more sense as an external entity. Regards, Anthony Liguori

[Qemu-devel] [PATCH 5/7] add json encoder for qobjects

2009-10-17 Thread Paolo Bonzini
The JSON encoder is just a virtual method on QObject. Cc: Luiz Capitulino Signed-off-by: Paolo Bonzini --- Makefile |4 ++-- qdict.c | 32 qint.c| 16 qlist.c | 28 qobject.h | 10 ++ qst