Re: [Qemu-devel] [PATCH 5/6] snapshot: qmp interface

2013-01-05 Thread Wenchao Xia
于 2013-1-5 0:22, Stefan Hajnoczi 写道: On Mon, Dec 17, 2012 at 02:25:08PM +0800, Wenchao Xia wrote: @@ -1478,16 +1497,39 @@ # # @device: the name of the device to generate the snapshot from. # -# @snapshot-file: the target of the new image. A new file will be created. +# @snapshot-file: the

Re: [Qemu-devel] [PATCH 5/6] snapshot: qmp interface

2013-01-04 Thread Stefan Hajnoczi
On Mon, Dec 17, 2012 at 02:25:08PM +0800, Wenchao Xia wrote: > @@ -1478,16 +1497,39 @@ > # > # @device: the name of the device to generate the snapshot from. > # > -# @snapshot-file: the target of the new image. A new file will be created. > +# @snapshot-file: the target name of the snapshot. I

Re: [Qemu-devel] [PATCH 5/6] snapshot: qmp interface

2013-01-04 Thread Eric Blake
On 01/03/2013 11:02 PM, Wenchao Xia wrote: > >>> +# case, it is the internal snapshot record's name >>> and if it is >>> +# 'blank' name will be generated according to time. >> >> Ugg. Passing an empty string for snapshot-file as a special case seems >> awkward; i

Re: [Qemu-devel] [PATCH 5/6] snapshot: qmp interface

2013-01-03 Thread Wenchao Xia
Thanks for reviewing, I'll correct the spelling. + +## # @NewImageMode # # An enumeration that tells QEMU how to set the backing file path in -# a new image file. +# a new image file, or how to use internal snapshot record. # -# @existing: QEMU should look for an existing image file. +

Re: [Qemu-devel] [PATCH 5/6] snapshot: qmp interface

2013-01-02 Thread Eric Blake
On 12/16/2012 11:25 PM, Wenchao Xia wrote: > This patch changes the implemtion of external block snapshot s/implemtion/implementation/ > to use internal unified interface, now qmp handler just do s/do/does/ > a translation of request and submit. > Also internal block snapshot qmp interface

[Qemu-devel] [PATCH 5/6] snapshot: qmp interface

2012-12-16 Thread Wenchao Xia
This patch changes the implemtion of external block snapshot to use internal unified interface, now qmp handler just do a translation of request and submit. Also internal block snapshot qmp interface was added. Now add external snapshot, add/delete internal snapshot can be started in their ow