Re: [Qemu-devel] [PATCH 5/6] hw/omap1.c: Separate clkm from omap_mpu_state

2012-01-04 Thread Peter Maydell
On 21 December 2011 11:07, Peter Maydell wrote: > On 21 December 2011 01:38, andrzej zaborowski wrote: >> Since this sub device uses parts of the rest of mpu state, it's >> (apparently) not a separate device, can we thus skip this change?  I >> don't see much value in it and it doesn't simplify c

Re: [Qemu-devel] [PATCH 5/6] hw/omap1.c: Separate clkm from omap_mpu_state

2011-12-21 Thread Peter Maydell
On 21 December 2011 01:38, andrzej zaborowski wrote: > Since this sub device uses parts of the rest of mpu state, it's > (apparently) not a separate device, can we thus skip this change?  I > don't see much value in it and it doesn't simplify code. If you like; I don't have a very strong feeling

Re: [Qemu-devel] [PATCH 5/6] hw/omap1.c: Separate clkm from omap_mpu_state

2011-12-20 Thread andrzej zaborowski
On 20 December 2011 19:11, Peter Maydell wrote: > From: Juha Riihimäki > > Signed-off-by: Juha Riihimäki > [Riku Voipio: Fixes and restructuring patchset] > Signed-off-by: Riku Voipio > [Peter Maydell: More fixes and cleanups for upstream submission] > Signed-off-by:  Peter Maydell > --- >  hw

[Qemu-devel] [PATCH 5/6] hw/omap1.c: Separate clkm from omap_mpu_state

2011-12-20 Thread Peter Maydell
From: Juha Riihimäki Signed-off-by: Juha Riihimäki [Riku Voipio: Fixes and restructuring patchset] Signed-off-by: Riku Voipio [Peter Maydell: More fixes and cleanups for upstream submission] Signed-off-by: Peter Maydell --- hw/omap.h | 16 +--- hw/omap1.c | 127 ++