Re: [Qemu-devel] [PATCH 5/6] error: Remove redundant error_printf_unless_qmp

2014-03-21 Thread Cole Robinson
On 03/12/2014 04:56 AM, Markus Armbruster wrote: > Cole Robinson writes: > >> error_printf is just a wrapper around monitor_printf, which already >> drops the requested output if cur_mon is qmp. > > Since commit 74ee59a: > > monitor: drop unused monitor debug code > > In the old QM

Re: [Qemu-devel] [PATCH 5/6] error: Remove redundant error_printf_unless_qmp

2014-03-12 Thread Markus Armbruster
Cole Robinson writes: > error_printf is just a wrapper around monitor_printf, which already > drops the requested output if cur_mon is qmp. Since commit 74ee59a: monitor: drop unused monitor debug code In the old QMP days, this code was used to find out QMP commands that might

[Qemu-devel] [PATCH 5/6] error: Remove redundant error_printf_unless_qmp

2014-03-11 Thread Cole Robinson
error_printf is just a wrapper around monitor_printf, which already drops the requested output if cur_mon is qmp. Cc: Luiz Capitulino Cc: Markus Armbruster Signed-off-by: Cole Robinson --- hw/usb/bus.c| 2 +- hw/usb/hcd-ehci.c | 4 ++-- include/qemu/error-report.h |