Re: [Qemu-devel] [PATCH 5/5] target-i386: implement machine->hot_add_cpu hook

2013-05-02 Thread Andreas Färber
Am 02.05.2013 09:18, schrieb Igor Mammedov: > On Wed, 01 May 2013 21:32:59 +0200 > Andreas Färber wrote: > >> I verified it's working as expected in Windows 2012 Datacenter, but >> neither in openSUSE 12.3 nor in Fedora 18 Live DVD did I see any change >> in /proc/cpuinfo or GNOME System Monitor.

Re: [Qemu-devel] [PATCH 5/5] target-i386: implement machine->hot_add_cpu hook

2013-05-02 Thread Igor Mammedov
On Wed, 01 May 2013 21:32:59 +0200 Andreas Färber wrote: > Am 30.04.2013 18:00, schrieb Igor Mammedov: > > Signed-off-by: Igor Mammedov > > --- > > v3: > > * use local static variable for saving cpu_model > > > > v2: > > * override .hot_add_cpu statically starting with 1.5 machine > > Than

Re: [Qemu-devel] [PATCH 5/5] target-i386: implement machine->hot_add_cpu hook

2013-05-01 Thread Andreas Färber
Am 30.04.2013 18:00, schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov > --- > v3: > * use local static variable for saving cpu_model > > v2: > * override .hot_add_cpu statically starting with 1.5 machine Thanks, applied to qom-cpu: https://github.com/afaerber/qemu-cpu/commits/qom-cpu I

[Qemu-devel] [PATCH 5/5] target-i386: implement machine->hot_add_cpu hook

2013-04-30 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v3: * use local static variable for saving cpu_model v2: * override .hot_add_cpu statically starting with 1.5 machine --- hw/i386/pc.c | 26 ++ hw/i386/pc_piix.c|1 + hw/i386/pc_q35.c |1 + include/hw/i386/pc.

Re: [Qemu-devel] [PATCH 5/5] target-i386: implement machine->hot_add_cpu hook

2013-04-30 Thread Eduardo Habkost
On Tue, Apr 30, 2013 at 06:00:53PM +0200, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Not the best solution (I believe I prefer the QEMUMachine.cpu_model alternative), but code looks correct, so: Reviewed-by: Eduardo Habkost > --- > v3: > * use local static variable for saving cpu_m

[Qemu-devel] [PATCH 5/5] target-i386: implement machine->hot_add_cpu hook

2013-04-30 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: * override .hot_add_cpu statically starting with 1.5 machine --- hw/i386/pc.c | 23 +++ hw/i386/pc_piix.c|1 + hw/i386/pc_q35.c |1 + include/hw/i386/pc.h |1 + 4 files changed, 26 insertions(+), 0 deletions(