Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

2015-11-24 Thread Peter Maydell
On 24 November 2015 at 21:45, Andrew Jones wrote: > On Tue, Nov 24, 2015 at 09:08:29PM +, Peter Maydell wrote: >> Also, if we're currently executing a 32-bit guest when we take >> the core dump, you probably need to call aarch64_sync_32_to_64() >> somewhere. > > I think we're covered here. We

Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

2015-11-24 Thread Andrew Jones
On Tue, Nov 24, 2015 at 09:08:29PM +, Peter Maydell wrote: > On 24 November 2015 at 20:52, Andrew Jones wrote: > > > > I've pulled a v2 together that I'll be testing and posting soon. Here's > > what I decided to do > > > > 1) Throw the fp registers in. Why not? > > 2) No linux-headers update,

Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

2015-11-24 Thread Peter Maydell
On 24 November 2015 at 20:52, Andrew Jones wrote: > > I've pulled a v2 together that I'll be testing and posting soon. Here's > what I decided to do > > 1) Throw the fp registers in. Why not? > 2) No linux-headers update, as we'd also need >include/uapi/linux/elfcore.h and arch/arm/include/asm

Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

2015-11-24 Thread Andrew Jones
On Sat, Nov 21, 2015 at 10:05:37AM -0500, Andrew Jones wrote: > On Fri, Nov 20, 2015 at 04:41:21PM -0500, Andrew Jones wrote: > > On Fri, Nov 20, 2015 at 06:19:14PM +, Peter Maydell wrote: > > > On 19 November 2015 at 14:53, Andrew Jones wrote: > > > > + > > > > +if (is_a64(env)) { > > >

Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

2015-11-21 Thread Andrew Jones
On Fri, Nov 20, 2015 at 04:41:21PM -0500, Andrew Jones wrote: > On Fri, Nov 20, 2015 at 06:19:14PM +, Peter Maydell wrote: > > On 19 November 2015 at 14:53, Andrew Jones wrote: > > > + > > > +if (is_a64(env)) { > > > > Are you really sure you want the core dump format to depend on > > whe

Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

2015-11-20 Thread Andrew Jones
On Fri, Nov 20, 2015 at 06:19:14PM +, Peter Maydell wrote: > On 19 November 2015 at 14:53, Andrew Jones wrote: > > Add the support needed for creating prstatus elf notes. This > > allows us to use QMP dump-guest-memory. > > > > Signed-off-by: Andrew Jones > > --- > > target-arm/Makefile.objs

Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

2015-11-20 Thread Peter Maydell
On 19 November 2015 at 14:53, Andrew Jones wrote: > Add the support needed for creating prstatus elf notes. This > allows us to use QMP dump-guest-memory. > > Signed-off-by: Andrew Jones > --- > target-arm/Makefile.objs | 3 +- > target-arm/arch_dump.c | 222 > ++

[Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

2015-11-19 Thread Andrew Jones
Add the support needed for creating prstatus elf notes. This allows us to use QMP dump-guest-memory. Signed-off-by: Andrew Jones --- target-arm/Makefile.objs | 3 +- target-arm/arch_dump.c | 222 +++ target-arm/cpu-qom.h | 5 ++ target-arm/cp