Re: [Qemu-devel] [PATCH 5/5] cpu: Add MachineState parameter to parse_features()

2019-04-16 Thread David Gibson
On Tue, Apr 16, 2019 at 11:59:44PM -0300, Eduardo Habkost wrote: > The ppc implementation of parse_features() requires the machine > object to be created before it gets called. This is far from > obvious when reading the code at main(). > > Instead of making it call qdev_get_machine(), require th

Re: [Qemu-devel] [PATCH 5/5] cpu: Add MachineState parameter to parse_features()

2019-04-16 Thread Markus Armbruster
Eduardo Habkost writes: > The ppc implementation of parse_features() requires the machine > object to be created before it gets called. This is far from > obvious when reading the code at main(). > > Instead of making it call qdev_get_machine(), require the caller > of parse_cpu_option() to prov

[Qemu-devel] [PATCH 5/5] cpu: Add MachineState parameter to parse_features()

2019-04-16 Thread Eduardo Habkost
The ppc implementation of parse_features() requires the machine object to be created before it gets called. This is far from obvious when reading the code at main(). Instead of making it call qdev_get_machine(), require the caller of parse_cpu_option() to provide the machine object. This makes t