Re: [Qemu-devel] [PATCH 5/5] block/nbd-client: don't check ioc

2018-05-07 Thread Vladimir Sementsov-Ogievskiy
07.05.2018 21:08, Eric Blake wrote: On 05/07/2018 10:44 AM, Vladimir Sementsov-Ogievskiy wrote: We have several paranoiac checks for ioc != NULL. But ioc may become NULL only on close, which should not happen during requests handling. Also, we check ioc only sometimes, not after each yield, whic

Re: [Qemu-devel] [PATCH 5/5] block/nbd-client: don't check ioc

2018-05-07 Thread Eric Blake
On 05/07/2018 10:44 AM, Vladimir Sementsov-Ogievskiy wrote: We have several paranoiac checks for ioc != NULL. But ioc may become NULL only on close, which should not happen during requests handling. Also, we check ioc only sometimes, not after each yield, which is inconsistent. Let's drop these c

[Qemu-devel] [PATCH 5/5] block/nbd-client: don't check ioc

2018-05-07 Thread Vladimir Sementsov-Ogievskiy
We have several paranoiac checks for ioc != NULL. But ioc may become NULL only on close, which should not happen during requests handling. Also, we check ioc only sometimes, not after each yield, which is inconsistent. Let's drop these checks. Signed-off-by: Vladimir Sementsov-Ogievskiy --- bloc