Re: [Qemu-devel] [PATCH 5/5] Separate migration thread

2011-08-30 Thread Marcelo Tosatti
On Tue, Aug 30, 2011 at 10:48:11AM +0200, Paolo Bonzini wrote: > On 08/29/2011 08:49 PM, Marcelo Tosatti wrote: > >>> -static void buffered_rate_tick(void *opaque) > >>> +static void *migrate_vm(void *opaque) > >>>{ > > > >buffered_file.c was generic code that has now become migration specifi

Re: [Qemu-devel] [PATCH 5/5] Separate migration thread

2011-08-30 Thread Paolo Bonzini
On 08/29/2011 08:49 PM, Marcelo Tosatti wrote: > -static void buffered_rate_tick(void *opaque) > +static void *migrate_vm(void *opaque) >{ buffered_file.c was generic code that has now become migration specific (although migration was the only user). So it should either stop pretending to

Re: [Qemu-devel] [PATCH 5/5] Separate migration thread

2011-08-29 Thread Marcelo Tosatti
On Sat, Aug 27, 2011 at 02:09:48PM -0400, Umesh Deshpande wrote: > This patch creates a separate thread for the guest migration on the source > side. > All exits (on completion/error) from the migration thread are handled by a > bottom handler, which is called from the iothread. > > Signed-off-by

Re: [Qemu-devel] [PATCH 5/5] Separate migration thread

2011-08-29 Thread Umesh Deshpande
On 08/29/2011 05:09 AM, Stefan Hajnoczi wrote: On Sat, Aug 27, 2011 at 7:09 PM, Umesh Deshpande wrote: This patch creates a separate thread for the guest migration on the source side. All exits (on completion/error) from the migration thread are handled by a bottom handler, which is called from

Re: [Qemu-devel] [PATCH 5/5] Separate migration thread

2011-08-29 Thread Stefan Hajnoczi
On Sat, Aug 27, 2011 at 7:09 PM, Umesh Deshpande wrote: > This patch creates a separate thread for the guest migration on the source > side. > All exits (on completion/error) from the migration thread are handled by a > bottom handler, which is called from the iothread. > > Signed-off-by: Umesh D

[Qemu-devel] [PATCH 5/5] Separate migration thread

2011-08-27 Thread Umesh Deshpande
This patch creates a separate thread for the guest migration on the source side. All exits (on completion/error) from the migration thread are handled by a bottom handler, which is called from the iothread. Signed-off-by: Umesh Deshpande --- buffered_file.c | 76 ---