Re: [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

2017-04-04 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> "Dr. David Alan Gilbert" wrote: >> > * Juan Quintela (quint...@redhat.com) wrote: >> >> We change the meaning of start to be the offset from the beggining of >> >> the block. >> > >> > s/beggining/beginning/ >> > >>

Re: [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

2017-03-30 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> We change the meaning of start to be the offset from the beggining of > >> the block. > > > > s/beggining/beginning/ > > > > Why do this? > > We have: > >migrati

Re: [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

2017-03-30 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> We change the meaning of start to be the offset from the beggining of >> the block. > > s/beggining/beginning/ > > Why do this? > We have: >migration_bitmap_sync (all blocks) >migration_bitmap_sync_range - ca

Re: [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

2017-03-30 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We change the meaning of start to be the offset from the beggining of > the block. s/beggining/beginning/ Why do this? We have: migration_bitmap_sync (all blocks) migration_bitmap_sync_range - called per block cpu_physical_memory_sync_dirty_

Re: [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

2017-03-28 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Yang Hongyang wrote: >> > On 2017/3/24 4:45, Juan Quintela wrote: >> >> We change the meaning of start to be the offset from the beggining of >> >> the block. >> >> >> >> @@ -701,7 +701,7 @@ static void migration_b

Re: [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

2017-03-28 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Yang Hongyang wrote: > > On 2017/3/24 4:45, Juan Quintela wrote: > >> We change the meaning of start to be the offset from the beggining of > >> the block. > >> > >> @@ -701,7 +701,7 @@ static void migration_bitmap_sync(RAMState *rs) > >> qemu_m

Re: [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

2017-03-24 Thread Juan Quintela
Yang Hongyang wrote: > Hi Juan, > > On 2017/3/24 16:29, Juan Quintela wrote: >> Yang Hongyang wrote: >>> On 2017/3/24 4:45, Juan Quintela wrote: We change the meaning of start to be the offset from the beggining of the block. @@ -701,7 +701,7 @@ static void migration_bitmap_sy

Re: [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

2017-03-24 Thread Yang Hongyang
Hi Juan, On 2017/3/24 16:29, Juan Quintela wrote: > Yang Hongyang wrote: >> On 2017/3/24 4:45, Juan Quintela wrote: >>> We change the meaning of start to be the offset from the beggining of >>> the block. >>> >>> @@ -701,7 +701,7 @@ static void migration_bitmap_sync(RAMState *rs) >>> qemu_mu

Re: [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

2017-03-24 Thread Juan Quintela
Yang Hongyang wrote: > On 2017/3/24 4:45, Juan Quintela wrote: >> We change the meaning of start to be the offset from the beggining of >> the block. >> >> @@ -701,7 +701,7 @@ static void migration_bitmap_sync(RAMState *rs) >> qemu_mutex_lock(&rs->bitmap_mutex); >> rcu_read_lock(); >>

Re: [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

2017-03-23 Thread Yang Hongyang
On 2017/3/24 4:45, Juan Quintela wrote: > We change the meaning of start to be the offset from the beggining of > the block. > > Signed-off-by: Juan Quintela > --- > include/exec/ram_addr.h | 2 ++ > migration/ram.c | 8 > 2 files changed, 6 insertions(+), 4 deletions(-) > > d

[Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

2017-03-23 Thread Juan Quintela
We change the meaning of start to be the offset from the beggining of the block. Signed-off-by: Juan Quintela --- include/exec/ram_addr.h | 2 ++ migration/ram.c | 8 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h