Re: [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.

2012-09-24 Thread Gerd Hoffmann
On 09/24/12 13:06, Stefano Stabellini wrote: > On Fri, 21 Sep 2012, Gerd Hoffmann wrote: >> Hi, >> +case FB_ACQ_REQ: +fbdev_switch_acquire(); +redraw_screen++; >>> >>> Rather than introducing redraw_screen, I would just call vga_hw_invalidate >>> instead here. I

Re: [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.

2012-09-24 Thread Stefano Stabellini
On Fri, 21 Sep 2012, Gerd Hoffmann wrote: > Hi, > > >> +case FB_ACQ_REQ: > >> +fbdev_switch_acquire(); > >> +redraw_screen++; > > > > Rather than introducing redraw_screen, I would just call vga_hw_invalidate > > instead here. It is always a win if we can avoid to introduce

Re: [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.

2012-09-21 Thread Gerd Hoffmann
Hi, >> +case FB_ACQ_REQ: >> +fbdev_switch_acquire(); >> +redraw_screen++; > > Rather than introducing redraw_screen, I would just call vga_hw_invalidate > instead here. It is always a win if we can avoid to introduce one more > state machine. Wouldn't that make the vga emul

Re: [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.

2012-09-19 Thread Blue Swirl
On Tue, Sep 18, 2012 at 7:17 AM, Gerd Hoffmann wrote: > Display works, requires truecolor framebuffer with 16 or 32 bpp on the > host. 32bpp is recommended. The framebuffer is used as-is, qemu > doesn't try to switch modes. With LCD displays mode switching is pretty > pointless IMHO, also it wo

Re: [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.

2012-09-19 Thread Stefano Stabellini
On Wed, 19 Sep 2012, Gerd Hoffmann wrote: > +/* */ > +/* rendering*/ > + > +static void fbdev_render(DisplayState *ds, int x, int y, int w, int h) > +{ > +uint8_t *ds

[Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.

2012-09-19 Thread Gerd Hoffmann
Display works, requires truecolor framebuffer with 16 or 32 bpp on the host. 32bpp is recommended. The framebuffer is used as-is, qemu doesn't try to switch modes. With LCD displays mode switching is pretty pointless IMHO, also it wouldn't work anyway with the most common fbdev drivers (vesafb,

Re: [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.

2012-09-18 Thread Gerd Hoffmann
On 09/18/12 17:01, Stefano Stabellini wrote: > On Tue, 18 Sep 2012, Gerd Hoffmann wrote: >> Display works, requires truecolor framebuffer with 16 or 32 bpp on the >> host. 32bpp is recommended. The framebuffer is used as-is, qemu >> doesn't try to switch modes. With LCD displays mode switching i

Re: [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.

2012-09-18 Thread Stefano Stabellini
On Tue, 18 Sep 2012, Gerd Hoffmann wrote: > Display works, requires truecolor framebuffer with 16 or 32 bpp on the > host. 32bpp is recommended. The framebuffer is used as-is, qemu > doesn't try to switch modes. With LCD displays mode switching is pretty > pointless IMHO, also it wouldn't work a

[Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.

2012-09-18 Thread Gerd Hoffmann
Display works, requires truecolor framebuffer with 16 or 32 bpp on the host. 32bpp is recommended. The framebuffer is used as-is, qemu doesn't try to switch modes. With LCD displays mode switching is pretty pointless IMHO, also it wouldn't work anyway with the most common fbdev drivers (vesafb,