Re: [Qemu-devel] [PATCH 4/9] address_space_write_continue: Distill common code

2016-07-12 Thread Andrey Smirnov
On Tue, Jul 12, 2016 at 8:41 AM, Peter Maydell wrote: > On 12 July 2016 at 16:28, Andrey Smirnov wrote: >> On Thu, Jul 7, 2016 at 8:38 PM, David Gibson >> wrote: >>> On Thu, Jul 07, 2016 at 04:33:38PM -0700, Andrey Smirnov wrote: Move call to memory_region_dispatch_write() outside of swtich

Re: [Qemu-devel] [PATCH 4/9] address_space_write_continue: Distill common code

2016-07-12 Thread Peter Maydell
On 12 July 2016 at 16:28, Andrey Smirnov wrote: > On Thu, Jul 7, 2016 at 8:38 PM, David Gibson > wrote: >> On Thu, Jul 07, 2016 at 04:33:38PM -0700, Andrey Smirnov wrote: >>> Move call to memory_region_dispatch_write() outside of swtich statement >>> since the only thing that is different about a

Re: [Qemu-devel] [PATCH 4/9] address_space_write_continue: Distill common code

2016-07-12 Thread Andrey Smirnov
On Thu, Jul 7, 2016 at 8:38 PM, David Gibson wrote: > On Thu, Jul 07, 2016 at 04:33:38PM -0700, Andrey Smirnov wrote: >> Move call to memory_region_dispatch_write() outside of swtich statement >> since the only thing that is different about all of those call is >> "length" argument and that matche

Re: [Qemu-devel] [PATCH 4/9] address_space_write_continue: Distill common code

2016-07-07 Thread David Gibson
On Thu, Jul 07, 2016 at 04:33:38PM -0700, Andrey Smirnov wrote: > Move call to memory_region_dispatch_write() outside of swtich statement > since the only thing that is different about all of those call is > "length" argument and that matches value in "l". Also collapse switch > statement to occupy