Re: [Qemu-devel] [PATCH 4/8] target-i386: Re-introduce optimal breakpoint removal

2015-09-18 Thread Eduardo Habkost
On Wed, Sep 16, 2015 at 10:57:57AM +0200, Paolo Bonzini wrote: [...] > Otherwise looks good, I'll write a kvm-unit-tests patch for this. I am planning to apply the series as soon as we get kvm-unit-tests results. If you think this is ready to get included as-is, even before we have it tested by k

Re: [Qemu-devel] [PATCH 4/8] target-i386: Re-introduce optimal breakpoint removal

2015-09-16 Thread Paolo Bonzini
On 16/09/2015 16:57, Richard Henderson wrote: >>> >> +/* Fold the global and local enable bits together into the >>> >> + global fields, then xor to show which registers have >>> >> + changed collective enable state. */ >>> >> +int mod = ((old_dr7 | old_dr7 *

Re: [Qemu-devel] [PATCH 4/8] target-i386: Re-introduce optimal breakpoint removal

2015-09-16 Thread Richard Henderson
On 09/16/2015 01:57 AM, Paolo Bonzini wrote: > > > On 15/09/2015 20:45, Richard Henderson wrote: >> +/* Fold the global and local enable bits together into the >> + global fields, then xor to show which registers have >> + changed collective enable state. */ >> +

Re: [Qemu-devel] [PATCH 4/8] target-i386: Re-introduce optimal breakpoint removal

2015-09-16 Thread Paolo Bonzini
On 15/09/2015 20:45, Richard Henderson wrote: > +/* Fold the global and local enable bits together into the > + global fields, then xor to show which registers have > + changed collective enable state. */ > +int mod = ((old_dr7 | old_dr7 * 2) ^ (new_dr7 | new_

[Qemu-devel] [PATCH 4/8] target-i386: Re-introduce optimal breakpoint removal

2015-09-15 Thread Richard Henderson
Before the last patch, we had an efficient loop that disabled local breakpoints on task switch. Re-add that, but in a more general way that handles changes to the global enable bits too. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 34 -- 1 fil