Re: [Qemu-devel] [PATCH 4/8] fdc: Use phase in fdctrl_write_data()

2015-05-19 Thread Peter Maydell
On 19 May 2015 at 16:35, Kevin Wolf wrote: > Instead of relying on a flag in the MSR to distinguish controller phases, > use the explicit phase that we store now. Assertions of the right MSR > flags are added. > > Signed-off-by: Kevin Wolf > --- > hw/block/fdc.c | 67 > +

Re: [Qemu-devel] [PATCH 4/8] fdc: Use phase in fdctrl_write_data()

2015-05-19 Thread John Snow
On 05/19/2015 11:35 AM, Kevin Wolf wrote: > Instead of relying on a flag in the MSR to distinguish controller phases, > use the explicit phase that we store now. Assertions of the right MSR > flags are added. > > Signed-off-by: Kevin Wolf > --- > hw/block/fdc.c | 67 >

[Qemu-devel] [PATCH 4/8] fdc: Use phase in fdctrl_write_data()

2015-05-19 Thread Kevin Wolf
Instead of relying on a flag in the MSR to distinguish controller phases, use the explicit phase that we store now. Assertions of the right MSR flags are added. Signed-off-by: Kevin Wolf --- hw/block/fdc.c | 67 ++ 1 file changed, 39 insert